Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added UT for validation API related components #252

Merged
merged 10 commits into from
May 26, 2022

Conversation

amitgalitz
Copy link
Member

Signed-off-by: Amit Galitzky [email protected]

Description

  • Added unit tests to a few classes, mostly all related to components that were altered by validation API.
  • Reformatted some code that was changed in 2.0 bump that I never ran prettier on.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitgalitz amitgalitz requested a review from a team April 27, 2022 20:51
@amitgalitz amitgalitz added test Adding or fixing tests infra Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Apr 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #252 (8f3e5b1) into main (96a0ab2) will increase coverage by 5.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   45.93%   51.32%   +5.38%     
==========================================
  Files         150      150              
  Lines        4957     4959       +2     
  Branches      956      956              
==========================================
+ Hits         2277     2545     +268     
+ Misses       2463     2161     -302     
- Partials      217      253      +36     
Impacted Files Coverage Δ
...s/AnomalyCharts/containers/AnomalyHeatmapChart.tsx 50.37% <0.00%> (-0.76%) ⬇️
...s-plugin/public/pages/utils/__tests__/constants.ts 100.00% <0.00%> (ø)
...in/public/pages/DefineDetector/utils/constants.tsx 100.00% <0.00%> (ø)
...verview/components/SampleDataBox/SampleDataBox.tsx 77.77% <0.00%> (ø)
...detection-dashboards-plugin/public/utils/utils.tsx 78.04% <0.00%> (+1.21%) ⬆️
...ic/pages/AnomalyCharts/utils/anomalyChartUtils.tsx 64.33% <0.00%> (+3.49%) ⬆️
.../DefineDetector/components/Timestamp/Timestamp.tsx 51.85% <0.00%> (+3.70%) ⬆️
...etector/components/DataFilterList/utils/helpers.ts 81.25% <0.00%> (+4.16%) ⬆️
...pages/DefineDetector/containers/DefineDetector.tsx 64.28% <0.00%> (+4.76%) ⬆️
...mponents/DataFilterList/components/FilterValue.tsx 20.83% <0.00%> (+8.33%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a0ab2...8f3e5b1. Read the comment docs.

@amitgalitz amitgalitz force-pushed the validation_unit_tests branch from 7316bf5 to c5d1789 Compare May 17, 2022 15:04
ohltyler
ohltyler previously approved these changes May 18, 2022
kaituo
kaituo previously approved these changes May 19, 2022
@amitgalitz amitgalitz dismissed stale reviews from kaituo and ohltyler via 8f3e5b1 May 24, 2022 16:48
@amitgalitz amitgalitz force-pushed the validation_unit_tests branch from f28e419 to 8f3e5b1 Compare May 24, 2022 16:48
@amitgalitz amitgalitz merged commit f95f52b into opensearch-project:main May 26, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 26, 2022
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit f95f52b)
amitgalitz added a commit that referenced this pull request May 27, 2022
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit f95f52b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc. test Adding or fixing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants