Add windows platform in CI workflow

[jackiehanyang]

Signed-off-by: Jackie Han [email protected]

Description

Add windows platform in CI workflow

Issues Resolved

#104

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #330 (1b7f0b3) into main (536171d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   52.04%   52.04%           
=======================================
  Files         147      147           
  Lines        5015     5015           
  Branches      965      965           
=======================================
  Hits         2610     2610           
  Misses       2148     2148           
  Partials      257      257           

Impacted Files	Coverage Δ
...es/DefineDetector/components/Settings/Settings.tsx	100.00% <0.00%> (ø)
...s/Overview/containers/AnomalyDetectionOverview.tsx	32.92% <0.00%> (ø)
...mponents/NameAndDescription/NameAndDescription.tsx	100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ohltyler]

Why is this in an array now?

[jackiehanyang]

otherwise new line will be recognized as actual new line in windows, but not in Ubuntu and macos. Sending you a screenshot offline.

Sorry, cannot find the screenshot anymore. But you can find the snapshot diff in this commit - faef809

[ohltyler]

So not sure, but why is this needed in an array and none of the others? I don't see any explicit newline in the text.

[jackiehanyang]

the original text is in three lines, 41, 42, 43. The actual Return key will somehow create an actual new line in windows. This is not the only place that long text uses an array to contain the hint text. Not sure why this long text wan't using an array when it was firstly added.

[ohltyler]

I see - I wonder why this only fails for 3 lines vs 2 lines. I see a bunch of places where 2 lines doesn't need an array...

[jackiehanyang]

Could you point me to where 2 lines doesn't need an array? I believe 2 lines will fail with the exact same reason as well, and I have addressed them all in this PR

[ohltyler]

I see this is for unit tests, what about for the integration tests?

[jackiehanyang]

I see this is for unit tests, what about for the integration tests?

the flaky integ tests has been failing since Sep 7, it's a separate issue than adding windows workflow. Let's get this adding windows workflow checked in first.

[ohltyler]

I see this is for unit tests, what about for the integration tests?

the flaky integ tests has been failing since Sep 7, it's a separate issue than adding windows workflow. Let's get this adding windows workflow checked in first.

I understand the flaky part, but from my understanding it's still a requirement for the 2.4 campaign.

I'm ok to treat the flaky test issue separately, but I think we should have the infrastructure set up to run with windows and get all of the non-flaky tests to pass.

[jackiehanyang]

I see this is for unit tests, what about for the integration tests?

the flaky integ tests has been failing since Sep 7, it's a separate issue than adding windows workflow. Let's get this adding windows workflow checked in first.

I understand the flaky part, but from my understanding it's still a requirement for the 2.4 campaign.

I'm ok to treat the flaky test issue separately, but I think we should have the infrastructure set up to run with windows and get all of the non-flaky tests to pass.

Sure, this PR is just for adding windows CI.

[ohltyler]

I see this is for unit tests, what about for the integration tests?

the flaky integ tests has been failing since Sep 7, it's a separate issue than adding windows workflow. Let's get this adding windows workflow checked in first.

I understand the flaky part, but from my understanding it's still a requirement for the 2.4 campaign.
I'm ok to treat the flaky test issue separately, but I think we should have the infrastructure set up to run with windows and get all of the non-flaky tests to pass.

Sure, this PR is just for adding windows CI.

The full windows CI is the integration tests though. Can that be added in this PR so we can close out the 2.4 issue?

[jackiehanyang]

I see this is for unit tests, what about for the integration tests?

the flaky integ tests has been failing since Sep 7, it's a separate issue than adding windows workflow. Let's get this adding windows workflow checked in first.

I understand the flaky part, but from my understanding it's still a requirement for the 2.4 campaign.

I'm ok to treat the flaky test issue separately, but I think we should have the infrastructure set up to run with windows and get all of the non-flaky tests to pass.

Sure, this PR is just for adding windows CI.

The full windows CI is the integration tests though. Can that be added in this PR so we can close out the 2.4 issue?

Checked map team package and dashboard team package. They all only added windows CI for unit tests. Plus, we don't even have integration tests for macOS. I think we are fine here just adding windows CI for unit tests. Let me know if you still have concerns.

[opensearch-trigger-bot]

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-330-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d8af1473501e1beb8d3fdef72dc814cb2040f5f6
# Push it to GitHub
git push --set-upstream origin backport/backport-330-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-330-to-1.3.

[ohltyler]

Will have a manual backport for this for 1.3 in #361