Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @osd/ui-framework package and replace KUI with OUI #1060

Open
2 of 9 tasks
tmarkley opened this issue Dec 30, 2021 · 4 comments
Open
2 of 9 tasks

Remove @osd/ui-framework package and replace KUI with OUI #1060

tmarkley opened this issue Dec 30, 2021 · 4 comments
Labels
discover for discover reinvent OUI Issues that require migration to OUI technical debt If not paid, jeapardizes long-term success and maintainability of the repository. ui library Issue or PR related to the UI component library ux / ui Improvements or additions to user experience, flows, components, UI elements

Comments

@tmarkley
Copy link
Contributor

tmarkley commented Dec 30, 2021

Visualizations, Timeline, Discover are just some of the areas of the code base that reference KUI and the other UI Framework components, but this package is related to multiple security vulnerabilities. We need to get rid of it. I will add more details as we dive deeper.

Related to #695

@tmarkley tmarkley added ux / ui Improvements or additions to user experience, flows, components, UI elements ui library Issue or PR related to the UI component library labels Dec 30, 2021
@tmarkley tmarkley changed the title [EUI] Remove @osd/ui-framework package and replace KUI with EUI Remove @osd/ui-framework package and replace KUI with EUI Dec 30, 2021
@tmarkley tmarkley added the technical debt If not paid, jeapardizes long-term success and maintainability of the repository. label May 25, 2022
@joshuarrrr
Copy link
Member

@tmarkley Can this be closed thanks to #1105?

@tmarkley
Copy link
Contributor Author

@tmarkley Can this be closed thanks to #1105?

No, we still have to replace all of the usages of the KUI components with EUI (or the new design system when we fork) components. See

export { KuiBar, KuiBarSection } from './bar';
export { KuiButton, KuiButtonGroup, KuiButtonIcon, KuiLinkButton, KuiSubmitButton } from './button';
export { KuiCollapseButton } from './collapse_button';
export {
KuiEmptyTablePrompt,
KuiEmptyTablePromptMessage,
KuiEmptyTablePromptPanel,
} from './empty_table_prompt';
export { KuiFieldGroup, KuiFieldGroupSection } from './form_layout';
export {
KuiLabel,
KuiTextInput,
KuiTextArea,
KuiSelect,
KuiCheckBox,
KuiCheckBoxLabel,
} from './form';
export {
KuiLocalNav,
KuiLocalNavRow,
KuiLocalNavRowSection,
KuiLocalTab,
KuiLocalTabs,
KuiLocalTitle,
} from './local_nav';
export { KuiPager, KuiPagerButtonGroup } from './pager';
export { KuiTabs, KuiTab } from './tabs';
export {
KuiTable,
KuiControlledTable,
KuiTableHeaderCell,
KuiTableRow,
KuiTableRowCell,
KuiTableInfo,
KuiTableRowCheckBoxCell,
KuiTableHeaderCheckBoxCell,
KuiTableHeader,
KuiTableBody,
KuiListingTable,
KuiListingTableCreateButton,
KuiListingTableDeleteButton,
KuiListingTableNoMatchesPrompt,
KuiListingTableLoadingPrompt,
} from './table';
export {
KuiToolBar,
KuiToolBarSearchBox,
KuiToolBarFooter,
KuiToolBarSection,
KuiToolBarFooterSection,
KuiToolBarText,
} from './tool_bar';

@tmarkley tmarkley changed the title Remove @osd/ui-framework package and replace KUI with EUI Remove @osd/ui-framework package and replace KUI with OUI Dec 3, 2022
@tmarkley
Copy link
Contributor Author

tmarkley commented Dec 3, 2022

Related to #1560. @ananzh are you working on replacing usages of KUI with OUI as you're removing Angular?

@joshuarrrr joshuarrrr added the discover for discover reinvent label Dec 9, 2022
@joshuarrrr
Copy link
Member

@tmarkley I made some related subtask issues to better track. And yes, we'll try to opportunistically clean these up when we migrate, deprecate, or rewrite the affected plugins.

@seanneumann seanneumann added the OUI Issues that require migration to OUI label May 18, 2023
@rednaksi91 rednaksi91 moved this to Todo in Look & Feel May 18, 2023
@rednaksi91 rednaksi91 removed the status in Look & Feel May 18, 2023
@rednaksi91 rednaksi91 moved this to Todo in Look & Feel May 18, 2023
@joshuarrrr joshuarrrr moved this from Todo to In Progress in Look & Feel Jun 14, 2023
@joshuarrrr joshuarrrr self-assigned this Jun 14, 2023
@joshuarrrr joshuarrrr removed their assignment Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discover for discover reinvent OUI Issues that require migration to OUI technical debt If not paid, jeapardizes long-term success and maintainability of the repository. ui library Issue or PR related to the UI component library ux / ui Improvements or additions to user experience, flows, components, UI elements
Projects
Status: In Progress
Development

No branches or pull requests

3 participants