Removes KUI Generator and related dependencies #1062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* precommit checks are failing with an error related to an lmdb-store dependency * unit tests are failing with an error related to lmdb-store * bumped react from 16.12 to 16.14 to resolve unmet peer dependencies, but we still need a resolution to remove the old version * need a replacement for @elastic/good Signed-off-by: Bishoy Boktor <[email protected]>
Signed-off-by: Bishoy Boktor <[email protected]>
…est issues (opensearch-project#1012) Signed-off-by: Bishoy Boktor <[email protected]>
Add unit tests to github workflow and also creating a "bad apples" environment variable. Some unit tests just fail on the CI for hardware issues. They should be improved but step one will be calling out the bad apples. Also due to the flakiness we can cache the previous run results and only run the tests that failed. It's too random to catch with the bad apples mechanism. But still added the continue on error for unit tests because it takes so long to re-run on the CI. So instead if it does fail we automatically echo there was a failure and ask them to re-run. However, if we can get permission for a github action that can add a comment to the PR then we could automatically add to PR. Next step will be improving. Also needed to limit the amount of workers because otherwise the hardware can't handle well so then it will accidentally create conflicts. This means we get an accurate test run but it is slower on the CI. Included integration tests which worked out of the box. Included e2e tests as well but it the chrome driver for the application was different from github's chrome so to run it I just upgraded it for the test run. Not ideal, ideally we should probably set up a docker env and install the specific versions since we are now depending on github's virtual env and the dependencies they installed there. But at least this is a first pace. Signed-off-by: Kawika Avilla <[email protected]>
* Adds `--no-deprecation` flag for integration tests caused by `shot` which is a downstream dependency of `hapi`. * The ServerMetricsCollector tests are flaky and rely on the existing v17 hapi library that Dashboards depends on. This will be upgraded for the 2.0 release along with the Node.js upgrade. Signed-off-by: Tommy Markley <[email protected]>
Signed-off-by: Bishoy Boktor <[email protected]>
Signed-off-by: Bishoy Boktor <[email protected]>
* KUI is deprecated and we will not be adding new components. * Removes all dependencies that are no longer used in the package. * Updates the README to reflect the deprecation path. * Removes the create and document component scripts as well as the remaining references to generator-kui. Resolves opensearch-project#1059 Resolves opensearch-project#1061 Signed-off-by: Tommy Markley <[email protected]>
tmarkley
added
dependencies
This was
linked to
issues
Dec 31, 2021
|
Closing this in favor of #1105 |
This was
unlinked from
issues
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This is targeting the
node-14branch since we still haven't merged #1028 intomainand this PR requires those changes.Related to #1060
Issues Resolved
N/A
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr