Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KUI usage in visualizations #3386

Open
3 tasks
Tracked by #1060
joshuarrrr opened this issue Feb 4, 2023 · 6 comments
Open
3 tasks
Tracked by #1060

Remove KUI usage in visualizations #3386

joshuarrrr opened this issue Feb 4, 2023 · 6 comments
Assignees
Labels
good first issue Good for newcomers technical debt If not paid, jeapardizes long-term success and maintainability of the repository. ui library Issue or PR related to the UI component library visualizations Issues and PRs related to visualizations

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Feb 4, 2023

Based on a quick initial search, this plugin only defines some kui classes in the DisabledLabVisualization component:

className="kuiVerticalRhythm visDisabledLabVisualization__icon kuiIcon fa-flask"

To resolve

  • This placeholder text and icon should be replaced with OuiEmptyPrompthttps://oui.opensearch.org/1.2/#/display/empty-prompt
  • The wording should be updated to remove "lab" and "lab mode" as those are Kibana terms - we also want to remove the word "please" as it doesn't align with our language styleguide. So the new text would read "[vispanel title] is an experimental visualization. Enable experimental visualizations within Advanced Settings. "
  • A deep link to the Visualizations panel in Advanced Settings should be placed in the message
@joshuarrrr joshuarrrr added good first issue Good for newcomers visualizations Issues and PRs related to visualizations technical debt If not paid, jeapardizes long-term success and maintainability of the repository. ui library Issue or PR related to the UI component library and removed untriaged labels Feb 4, 2023
@sayuree
Copy link
Contributor

sayuree commented Mar 28, 2023

@joshuarrrr Hello, I want to work on this issue, can you please assign it to me?

@sayuree
Copy link
Contributor

sayuree commented Mar 29, 2023

@joshuarrrr You have highlighted kuiVerticalRhythm class to be renamed to have component scoped class name, however, in the SCSS file we also have classes starting from kui such as:

  • kuiVerticalRhythmSmall
  • kuiVerticalRhythmLarge
  • kuiVerticalRhythmXLarge
    I assume that they also should be renamed, right?

@joshuarrrr
Copy link
Member Author

We're not actually interested in renaming the KUI classes themselves, because we want to get rid of KUI altogether. What this issue aims to do is to remove any KUI classes added to elements in the visualize plugin, without changing the actual CSS applied to those elements. So while there are many other KUI classes defined, we only care about the ones that are still in use and providing styles of some sort.

@BSFishy
Copy link
Contributor

BSFishy commented Oct 4, 2023

@sayuree are you still working on this issue? It seems to be stale. If not, we'd like to unassign you.

@caileyjen
Copy link

caileyjen commented Oct 4, 2023

Hello! I'm interested in continuing work on this issue, could you please assign it to me @joshuarrrr @BSFishy ?

@joshuarrrr
Copy link
Member Author

@caileyjen This issue has some updated requirements we discovered in the first PR - I'll try and update the issue description, but make sure to read #3855 (comment) for the mitigation required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers technical debt If not paid, jeapardizes long-term success and maintainability of the repository. ui library Issue or PR related to the UI component library visualizations Issues and PRs related to visualizations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants