Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KUI usage in maps_legacy #3829

Closed
Tracked by #1060
joshuarrrr opened this issue Apr 11, 2023 · 2 comments · Fixed by #3998
Closed
Tracked by #1060

Remove KUI usage in maps_legacy #3829

joshuarrrr opened this issue Apr 11, 2023 · 2 comments · Fixed by #3998
Assignees
Labels
good first issue Good for newcomers help wanted Community development is encouraged maps Issues or PRs related to the Maps Service OUI Issues that require migration to OUI technical debt If not paid, jeapardizes long-term success and maintainability of the repository. ux / ui Improvements or additions to user experience, flows, components, UI elements

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Apr 11, 2023

The maps_legacy plugin uses a single .kui* namespaced class. See https://github.com/search?q=repo%3Aopensearch-project%2FOpenSearch-Dashboards+kui+NOT+trackUI+path%3A%2F%5Esrc%5C%2Fplugins%5C%2Fmaps_legacy%2F&type=code

To resolve

Investigate and inspect the applied CSS of that class and the rendered component. If necessary:

  1. Document CSS rules provided by these classes
  2. Replace these components with OUI components

Note that maps_legacy is a plugin dependency of the tile_map and vis_type_vega plugins, so this change should be tested in both of those cases.

@joshuarrrr joshuarrrr added good first issue Good for newcomers help wanted Community development is encouraged maps Issues or PRs related to the Maps Service and removed untriaged labels Apr 11, 2023
@joshuarrrr joshuarrrr changed the title Remove KUI usage in maps_legacy Remove KUI usage in maps_legacy or deprecate Apr 11, 2023
@joshuarrrr joshuarrrr changed the title Remove KUI usage in maps_legacy or deprecate Remove KUI usage in maps_legacy Apr 11, 2023
@joshuarrrr joshuarrrr added ux / ui Improvements or additions to user experience, flows, components, UI elements technical debt If not paid, jeapardizes long-term success and maintainability of the repository. labels Apr 11, 2023
@curq
Copy link
Collaborator

curq commented Apr 15, 2023

@joshuarrrr Can you please assign this issue to me?

@miamia1999
Copy link
Contributor

Could you, also, assign this issue to me?

@seanneumann seanneumann added the OUI Issues that require migration to OUI label May 18, 2023
@rednaksi91 rednaksi91 moved this to In Progress in Look & Feel May 18, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Look & Feel Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Community development is encouraged maps Issues or PRs related to the Maps Service OUI Issues that require migration to OUI technical debt If not paid, jeapardizes long-term success and maintainability of the repository. ux / ui Improvements or additions to user experience, flows, components, UI elements
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants