Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor usage of .kui* classes in tests #3387

Open
Tracked by #1060
joshuarrrr opened this issue Feb 4, 2023 · 3 comments
Open
Tracked by #1060

Refactor usage of .kui* classes in tests #3387

joshuarrrr opened this issue Feb 4, 2023 · 3 comments
Assignees
Labels
good first issue Good for newcomers technical debt If not paid, jeapardizes long-term success and maintainability of the repository. test:functional ui library Issue or PR related to the UI component library

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Feb 4, 2023

The only usage I spotted was in this functional test:

const links = await find.allByCssSelector('.kuiLink');

It seems like it would be relatively straightforward to add a test id or use another existing class to identify those links.

It may also be worth just migrating/refactoring that test case to https://github.com/opensearch-project/opensearch-dashboards-functional-test as per #2491

@joshuarrrr joshuarrrr added test:functional good first issue Good for newcomers technical debt If not paid, jeapardizes long-term success and maintainability of the repository. ui library Issue or PR related to the UI component library and removed untriaged labels Feb 4, 2023
@sayuree
Copy link
Contributor

sayuree commented Mar 28, 2023

@joshuarrrr So we need to rename existing class and its occurrences, right? Do we still need to migrate it to https://github.com/opensearch-project/opensearch-dashboards-functional-test?

@joshuarrrr
Copy link
Member Author

So we need to rename existing class and its occurrences, right?

Yeah, although it will need some investigation - you may not even need to rename the class if there's another way to reference those elements. Or a test-id may be a better choice.

Do we still need to migrate it to https://github.com/opensearch-project/opensearch-dashboards-functional-test?

Yes, but let's do that in a separate PR. So the first PR will remove the class and update the existing test, and the second PR will be to migrate/recreate the test in the functional test repository.

@Aigerim-ai
Copy link
Contributor

I spotted kui here as well, but I it has its test ID

Screenshot 2023-04-02 at 13 48 45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers technical debt If not paid, jeapardizes long-term success and maintainability of the repository. test:functional ui library Issue or PR related to the UI component library
Projects
None yet
3 participants