[REVIEW]: A MATLAB toolbox to detect and analyze marine heatwaves #1124

whedon · 2018-12-10T17:56:46Z

Submitting author: @ZijieZhaoMMHW (Zijie Zhao)
Repository: https://github.com/ZijieZhaoMMHW/m_mhw1.0
Version: v1.0
Editor: @kthyng
Reviewer: @mvdh7
Archive: 10.5281/zenodo.2545437

Status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/088c8391f6c863e4a48ecf2530c5f13f"><img src="http://joss.theoj.org/papers/088c8391f6c863e4a48ecf2530c5f13f/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/088c8391f6c863e4a48ecf2530c5f13f/status.svg)](http://joss.theoj.org/papers/088c8391f6c863e4a48ecf2530c5f13f)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@mvdh7, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

Make sure you're logged in to your GitHub account
Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @kthyng know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @mvdh7

Conflict of interest

As the reviewer I confirm that I have read the JOSS conflict of interest policy and that there are no conflicts of interest for me to review this work.

Code of Conduct

I confirm that I read and will adhere to the JOSS code of conduct.

General checks

Repository: Is the source code for this software available at the repository url?
License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
Version: Does the release version given match the GitHub release (v1.0)?
Authorship: Has the submitting author (@ZijieZhaoMMHW) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

Installation: Does installation proceed as outlined in the documentation?
Functionality: Have the functional claims of the software been confirmed?
Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

Authors: Does the paper.md file include a list of authors with their affiliations?
A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

The text was updated successfully, but these errors were encountered:

whedon · 2018-12-10T17:56:49Z

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @mvdh7 it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

For a list of things I can do to help you, just type:

@whedon commands

whedon · 2018-12-10T17:56:49Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2018-12-10T17:57:35Z

👉 Check article proof 📄 👈

ZijieZhaoMMHW · 2018-12-17T01:09:54Z

@whedon commands

ZijieZhaoMMHW · 2018-12-17T01:12:38Z

@whedon generate pdf

whedon · 2018-12-17T01:12:41Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2018-12-17T01:13:09Z

👉 Check article proof 📄 👈

kthyng · 2019-01-06T19:19:59Z

Hi @mvdh7! How are things going on your end with this review? Pinged you on twitter too in case you still aren't getting notifications here.

mvdh7 · 2019-01-07T11:55:12Z

Sorry for delay. Do I just post comments here?

kthyng · 2019-01-07T15:45:25Z

@mvdh7 Please use the checklist and information in the first comment on this issue up above. The checklist will help guide you through, checking off as things are found to be ok. We ask that you open new github issues for anything more than a comment, and link them to this review. Putting an overview comment in here is helpful to summarize and say if you are satisfied or what the current state is. Let me know if you have other questions!

mvdh7 · 2019-01-08T09:07:49Z

Thanks @kthyng. @ZijieZhaoMMHW & co have done a great job in making this analysis available on MATLAB, and I'm sure this will be a very useful tool in the future. But there are a few issues that I think need to be resolved before publication in JOSS. I have ticked all the review boxes that I think I can at this point, & added all the corresponding issues.

kthyng · 2019-01-08T18:54:47Z

Great, thanks so much @mvdh7.

@ZijieZhaoMMHW please start addressing these issues as soon as you can. Thanks.

ZijieZhaoMMHW · 2019-01-09T01:35:06Z

Sorry for late reply, I was on flight yesterday and just back to work today. @mvdh7 Thanks for your careful review and pointed issues, I would try to address all issues this week and get back to you. @kthyng

ZijieZhaoMMHW · 2019-01-10T02:59:05Z

@whedon generate pdf

whedon · 2019-01-10T02:59:07Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-01-10T02:59:19Z

PDF failed to compile for issue #1124 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 16 0 16 0 0 266 0 --:--:-- --:--:-- --:--:-- 271
Error reading bibliography ./paper.bib (line 10, column 3):
unexpected "u"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

ZijieZhaoMMHW · 2019-01-10T03:00:56Z

@whedon generate pdf

whedon · 2019-01-10T03:00:58Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-01-10T03:01:11Z

PDF failed to compile for issue #1124 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 16 0 16 0 0 173 0 --:--:-- --:--:-- --:--:-- 173
Error reading bibliography ./paper.bib (line 10, column 3):
unexpected "u"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

ZijieZhaoMMHW · 2019-01-10T03:12:12Z

@whedon generate pdf

whedon · 2019-01-10T03:12:15Z

Attempting PDF compilation. Reticulating splines etc...

mvdh7 · 2019-01-11T19:04:20Z

Okay @kthyng. Will try my best to get things wrapped up before then

mvdh7 · 2019-01-21T11:00:07Z

Sorry for further delays. I think it's all now good to go. @lheagy @kthyng @ZijieZhaoMMHW

ooo · 2019-01-21T11:00:09Z

👋 Hey @mvdh7...

Letting you know, @kthyng is currently OOO until Sunday, March 31st 2019. ❤️

ZijieZhaoMMHW · 2019-01-21T11:29:20Z

@mvdh7 Thanks for careful review and suggestion.
@lheagy @kthyng It is now available on 10.5281/zenodo.2545360

ooo · 2019-01-21T11:29:21Z

👋 Hey @ZijieZhaoMMHW...

Letting you know, @kthyng is currently OOO until Sunday, March 31st 2019. ❤️

ZijieZhaoMMHW · 2019-01-21T11:31:51Z

https://doi.org/10.5281/zenodo.2545360

arfon · 2019-01-21T12:08:03Z

@ZijieZhaoMMHW - could you please rename your LICENCE.txt to LICENSE.txt and move it to the root (top level) of your repository please?

ZijieZhaoMMHW · 2019-01-21T12:10:24Z

@arfon Done. Sorry for that.

arfon · 2019-01-21T12:16:54Z

Thanks @ZijieZhaoMMHW. Could you update the Zenodo archive with this change too please?

ZijieZhaoMMHW · 2019-01-21T12:23:06Z

@arfon https://doi.org/10.5281/zenodo.2545437 sorry, I think it is ok now.

arfon · 2019-01-21T12:24:46Z

@whedon set 10.5281/zenodo.2545437 as archive

whedon · 2019-01-21T12:24:50Z

OK. 10.5281/zenodo.2545437 is the archive.

arfon · 2019-01-21T12:25:16Z

@whedon accept

whedon · 2019-01-21T12:25:19Z

Attempting dry run of processing paper acceptance...

whedon · 2019-01-21T12:25:56Z

Check final proof 👉 openjournals/joss-papers#445

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#445, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

arfon · 2019-01-21T12:27:23Z

@whedon accept deposit=true

whedon · 2019-01-21T12:27:26Z

Doing it live! Attempting automated processing of paper acceptance...

whedon · 2019-01-21T12:28:10Z

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.01124 joss-papers#446
Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01124
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

arfon · 2019-01-21T12:30:41Z

@mvdh7 - many thanks for your review here and to @kthyng for editing this submission ✨

@ZijieZhaoMMHW - your paper is now accepted into JOSS ⚡🚀💥

ooo · 2019-01-21T12:30:43Z

👋 Hey @arfon...

Letting you know, @kthyng is currently OOO until Sunday, March 31st 2019. ❤️

whedon · 2019-01-21T12:30:44Z

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.01124/status.svg)](https://doi.org/10.21105/joss.01124)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01124">
  <img src="http://joss.theoj.org/papers/10.21105/joss.01124/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.01124/status.svg
   :target: https://doi.org/10.21105/joss.01124

This is how it will look in your documentation:

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: http://joss.theoj.org/reviewer-signup.html
Making a small donation to support our running costs here: https://www.flipcause.com/secure/cause_pdetails/Mjk3Nzk=

whedon assigned kthyng Dec 10, 2018

whedon added the review label Dec 10, 2018

whedon mentioned this issue Dec 10, 2018

[PRE REVIEW]: A MATLAB toolbox to detect and analyze marine heatwaves #1074

Closed

whedon added the accepted label Jan 21, 2019

arfon closed this as completed Jan 21, 2019

ooo bot mentioned this issue Jan 27, 2019

[REVIEW]: HRDS: A Python package for hierarchical raster datasets #1112

Closed

36 tasks

ooo bot mentioned this issue Feb 9, 2019

[PRE REVIEW]: Rclean: A Tool for Writing Cleaner, More Transparent Code #1242

Closed

ooo bot mentioned this issue Mar 26, 2019

[PRE REVIEW]: pyCeterisParibus: explaining Machine Learning models with Ceteris Paribus Profiles in Python #1348

Closed

whedon added published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. labels Mar 2, 2020

editorialbot mentioned this issue Oct 2, 2023

[PRE REVIEW]: TOMRAP: Tool for Multihazard Risk Analysis in Python #5920

Closed

editorialbot mentioned this issue Sep 25, 2024

[PRE REVIEW]: respdetect: A Matlab tool for detecting breath events from whale biologger data #7282

Open

[REVIEW]: A MATLAB toolbox to detect and analyze marine heatwaves #1124

[REVIEW]: A MATLAB toolbox to detect and analyze marine heatwaves #1124

Comments

whedon commented Dec 10, 2018 • edited Loading

Status

Reviewer instructions & questions

Review checklist for @mvdh7

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented Dec 10, 2018

whedon commented Dec 10, 2018

whedon commented Dec 10, 2018

ZijieZhaoMMHW commented Dec 17, 2018

ZijieZhaoMMHW commented Dec 17, 2018

whedon commented Dec 17, 2018

whedon commented Dec 17, 2018

kthyng commented Jan 6, 2019

mvdh7 commented Jan 7, 2019

kthyng commented Jan 7, 2019

mvdh7 commented Jan 8, 2019

kthyng commented Jan 8, 2019

ZijieZhaoMMHW commented Jan 9, 2019

ZijieZhaoMMHW commented Jan 10, 2019

whedon commented Jan 10, 2019

whedon commented Jan 10, 2019

ZijieZhaoMMHW commented Jan 10, 2019

whedon commented Jan 10, 2019

whedon commented Jan 10, 2019

ZijieZhaoMMHW commented Jan 10, 2019

whedon commented Jan 10, 2019

mvdh7 commented Jan 11, 2019

mvdh7 commented Jan 21, 2019

ooo bot commented Jan 21, 2019

ZijieZhaoMMHW commented Jan 21, 2019

ooo bot commented Jan 21, 2019

ZijieZhaoMMHW commented Jan 21, 2019

arfon commented Jan 21, 2019

ZijieZhaoMMHW commented Jan 21, 2019

arfon commented Jan 21, 2019

ZijieZhaoMMHW commented Jan 21, 2019

arfon commented Jan 21, 2019

whedon commented Jan 21, 2019

arfon commented Jan 21, 2019

whedon commented Jan 21, 2019

whedon commented Jan 21, 2019

arfon commented Jan 21, 2019

whedon commented Jan 21, 2019

whedon commented Jan 21, 2019

arfon commented Jan 21, 2019

ooo bot commented Jan 21, 2019

whedon commented Jan 21, 2019

whedon commented Dec 10, 2018 •

edited

Loading