Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: respdetect: A Matlab tool for detecting breath events from whale biologger data #7282

Open
editorialbot opened this issue Sep 25, 2024 · 33 comments
Labels
Matlab pre-review TeX Track: 6 (ESE) Earth Sciences and Ecology waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @ashleyblawas (Ashley Blawas)
Repository: https://github.com/ashleyblawas/respdetect
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: Pending
Reviewers: Pending
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a23ed8e527ddeac304d76252a39d8b57"><img src="https://joss.theoj.org/papers/a23ed8e527ddeac304d76252a39d8b57/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a23ed8e527ddeac304d76252a39d8b57/status.svg)](https://joss.theoj.org/papers/a23ed8e527ddeac304d76252a39d8b57)

Author instructions

Thanks for submitting your paper to JOSS @ashleyblawas. Currently, there isn't a JOSS editor assigned to your paper.

@ashleyblawas if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Sep 25, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (934.9 files/s, 105773.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
MATLAB                          17            368            464           1262
TeX                              1             13              0            167
Markdown                         2             22              0             56
YAML                             1              1              4             19
-------------------------------------------------------------------------------
SUM:                            21            404            468           1504
-------------------------------------------------------------------------------

Commit count by author:

   177	Ashley Blawas

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1093/icb/45.2.305 is OK
- 10.1016/j.dsr2.2007.01.001 is OK
- 10.1016/j.dsr2.2006.11.009 is OK
- 10.1126/science.aao2740 is OK
- 10.1242/jeb.023366 is OK
- 10.1242/jeb.137513 is OK
- 10.1016/j.jembe.2014.05.014 is OK
- 10.1073/pnas.1914273116 is OK
- 10.1139/Z10-080 is OK
- 10.1139/z83-086 is OK
- 10.1111/j.1748-1716.1995.tb09834.x is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- 10.1242/jeb.243872 may be a valid DOI for title: An accelerometer-derived ballistocardiogram method...

❌ INVALID DOIs

- https://doi.org/10.1111/j.1748-7692.2008.00255.x is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 696

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

A MATLAB toolbox to detect and analyze marine heatwaves
Submitting author: @ZijieZhaoMMHW
Handling editor: @kthyng (Active)
Reviewers: @mvdh7
Similarity score: 0.6439

mmrefpoints: Projecting long-term marine mammal abundance with bycatch
Submitting author: @mcsiple
Handling editor: @fboehm (Active)
Reviewers: @ha0ye, @tbrown122387
Similarity score: 0.6429

biopeaks: a graphical user interface for feature extraction from heart- and breathing biosignals
Submitting author: @JanCBrammer
Handling editor: @oliviaguest (Active)
Reviewers: @TomDonoghue, @sappelhoff, @jamesheathers
Similarity score: 0.6341

ocean_data_tools: A MATLAB toolbox for interacting with bulk freely-available oceanographic data
Submitting author: @lnferris
Handling editor: @kthyng (Active)
Reviewers: @kakearney, @castelao
Similarity score: 0.6278

MorphoMetriX: a photogrammetric measurement GUI for morphometric analysis of megafauna
Submitting author: @wingtorres
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @isaacvandor, @bw4sz
Similarity score: 0.6223

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kthyng
Copy link

kthyng commented Sep 25, 2024

Hi @ashleyblawas and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

@ashleyblawas
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

mmrefpoints: Projecting long-term marine mammal abundance with bycatch
Submitting author: @mcsiple
Handling editor: @fboehm (Active)
Reviewers: @ha0ye, @tbrown122387
Similarity score: 0.6373

A MATLAB toolbox to detect and analyze marine heatwaves
Submitting author: @ZijieZhaoMMHW
Handling editor: @kthyng (Active)
Reviewers: @mvdh7
Similarity score: 0.6338

biopeaks: a graphical user interface for feature extraction from heart- and breathing biosignals
Submitting author: @JanCBrammer
Handling editor: @oliviaguest (Active)
Reviewers: @TomDonoghue, @sappelhoff, @jamesheathers
Similarity score: 0.6335

MorphoMetriX: a photogrammetric measurement GUI for morphometric analysis of megafauna
Submitting author: @wingtorres
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @isaacvandor, @bw4sz
Similarity score: 0.6206

spiro: An R package for analyzing data from cardiopulmonary exercise testing
Submitting author: @smnnlt
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @Kevin-Mattheus-Moerman
Similarity score: 0.6196

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@ashleyblawas
Copy link

Potential Reviewers: smnnlt, peterakirk, abhishektha, platipodium,bastienqueste

@kthyng
Copy link

kthyng commented Sep 27, 2024

@ashleyblawas

  • any plans to make a matlab package for more seamless installation?
  • maybe make it more obvious there is a wiki with a link in your readme
  • The "plotting" in the wiki didn't have a plot?
  • test directory just seems to have .mat files — no test code?

@ashleyblawas
Copy link

  • This toolbox can be installed directly by downloading the repository and adding its path to Matlab so it does not save the user significant effort to instead install through a Matlab package
  • I added a more obvious link to the Wiki in the Usage section of the readme
  • This can been updated to add the plots that were missing!
  • These test files are intended to be manually run through the series of processing steps. There is a built-in function within main.m to automatically compare the outputs of the two manual tests to the validation files also included in the test folder

@kthyng
Copy link

kthyng commented Oct 23, 2024

These test files are intended to be manually run through the series of processing steps. There is a built-in function within main.m to automatically compare the outputs of the two manual tests to the validation files also included in the test folder

Is this meant to be described in step 7 in the wiki? If so, are the subsequent steps 7a and 7b missing, which would walk the user through the testing to see if the code is working correctly?

@kthyng
Copy link

kthyng commented Oct 23, 2024

@ashleyblawas

@kthyng
Copy link

kthyng commented Nov 4, 2024

@ashleyblawas I have a few questions then we can move to finding an editor.

@kthyng
Copy link

kthyng commented Nov 12, 2024

@ashleyblawas Checking in here.

@kthyng kthyng added the paused label Nov 12, 2024
@ashleyblawas
Copy link

Not sure if this is regarding the initial DOI issues on Sept. 25th but those are all corrected now. The inline reference issues have also been corrected.

@ashleyblawas
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

mmrefpoints: Projecting long-term marine mammal abundance with bycatch
Submitting author: @mcsiple
Handling editor: @fboehm (Active)
Reviewers: @ha0ye, @tbrown122387
Similarity score: 0.6312

A MATLAB toolbox to detect and analyze marine heatwaves
Submitting author: @ZijieZhaoMMHW
Handling editor: @kthyng (Active)
Reviewers: @mvdh7
Similarity score: 0.6308

biopeaks: a graphical user interface for feature extraction from heart- and breathing biosignals
Submitting author: @JanCBrammer
Handling editor: @oliviaguest (Active)
Reviewers: @TomDonoghue, @sappelhoff, @jamesheathers
Similarity score: 0.6306

ocean_data_tools: A MATLAB toolbox for interacting with bulk freely-available oceanographic data
Submitting author: @lnferris
Handling editor: @kthyng (Active)
Reviewers: @kakearney, @castelao
Similarity score: 0.6211

MorphoMetriX: a photogrammetric measurement GUI for morphometric analysis of megafauna
Submitting author: @wingtorres
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @isaacvandor, @bw4sz
Similarity score: 0.6137

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@ashleyblawas
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

mmrefpoints: Projecting long-term marine mammal abundance with bycatch
Submitting author: @mcsiple
Handling editor: @fboehm (Active)
Reviewers: @ha0ye, @tbrown122387
Similarity score: 0.6426

biopeaks: a graphical user interface for feature extraction from heart- and breathing biosignals
Submitting author: @JanCBrammer
Handling editor: @oliviaguest (Active)
Reviewers: @TomDonoghue, @sappelhoff, @jamesheathers
Similarity score: 0.6353

A MATLAB toolbox to detect and analyze marine heatwaves
Submitting author: @ZijieZhaoMMHW
Handling editor: @kthyng (Active)
Reviewers: @mvdh7
Similarity score: 0.6338

ocean_data_tools: A MATLAB toolbox for interacting with bulk freely-available oceanographic data
Submitting author: @lnferris
Handling editor: @kthyng (Active)
Reviewers: @kakearney, @castelao
Similarity score: 0.6243

spiro: An R package for analyzing data from cardiopulmonary exercise testing
Submitting author: @smnnlt
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @Kevin-Mattheus-Moerman
Similarity score: 0.6243

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@ashleyblawas
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

biopeaks: a graphical user interface for feature extraction from heart- and breathing biosignals
Submitting author: @JanCBrammer
Handling editor: @oliviaguest (Active)
Reviewers: @TomDonoghue, @sappelhoff, @jamesheathers
Similarity score: 0.6388

mmrefpoints: Projecting long-term marine mammal abundance with bycatch
Submitting author: @mcsiple
Handling editor: @fboehm (Active)
Reviewers: @ha0ye, @tbrown122387
Similarity score: 0.6266

A MATLAB toolbox to detect and analyze marine heatwaves
Submitting author: @ZijieZhaoMMHW
Handling editor: @kthyng (Active)
Reviewers: @mvdh7
Similarity score: 0.6250

spiro: An R package for analyzing data from cardiopulmonary exercise testing
Submitting author: @smnnlt
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @Kevin-Mattheus-Moerman
Similarity score: 0.6194

ocean_data_tools: A MATLAB toolbox for interacting with bulk freely-available oceanographic data
Submitting author: @lnferris
Handling editor: @kthyng (Active)
Reviewers: @kakearney, @castelao
Similarity score: 0.6129

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@ashleyblawas
Copy link

These test files are intended to be manually run through the series of processing steps. There is a built-in function within main.m to automatically compare the outputs of the two manual tests to the validation files also included in the test folder

Is this meant to be described in step 7 in the wiki? If so, are the subsequent steps 7a and 7b missing, which would walk the user through the testing to see if the code is working correctly?

This has been addressed to make it more clear how the user should use Step 7 for testing, including a more thorough description of Steps 7a & 7b.

@kthyng
Copy link

kthyng commented Dec 2, 2024

Please check that your inline vs. parenthetical references are correct. You can compare with the example paper here: https://joss.readthedocs.io/en/latest/example_paper.html — line 32.

This has been addressed to make it more clear how the user should use Step 7 for testing, including a more thorough description of Steps 7a & 7b.

I see there is some description. Jumping there and reading it, I wouldn't know how to do the testing, but I'll let the reviewers comment on it if they choose to do so.

We have a backlog of submissions so I will add this to our waitlist. Thanks for your patience.

@kthyng kthyng added waitlisted Submissions in the JOSS backlog due to reduced service mode. and removed paused labels Dec 2, 2024
@ashleyblawas
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

biopeaks: a graphical user interface for feature extraction from heart- and breathing biosignals
Submitting author: @JanCBrammer
Handling editor: @oliviaguest (Active)
Reviewers: @TomDonoghue, @sappelhoff, @jamesheathers
Similarity score: 0.6360

mmrefpoints: Projecting long-term marine mammal abundance with bycatch
Submitting author: @mcsiple
Handling editor: @fboehm (Active)
Reviewers: @ha0ye, @tbrown122387
Similarity score: 0.6225

A MATLAB toolbox to detect and analyze marine heatwaves
Submitting author: @ZijieZhaoMMHW
Handling editor: @kthyng (Active)
Reviewers: @mvdh7
Similarity score: 0.6200

spiro: An R package for analyzing data from cardiopulmonary exercise testing
Submitting author: @smnnlt
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @Kevin-Mattheus-Moerman
Similarity score: 0.6165

MorphoMetriX: a photogrammetric measurement GUI for morphometric analysis of megafauna
Submitting author: @wingtorres
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @isaacvandor, @bw4sz
Similarity score: 0.6097

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Matlab pre-review TeX Track: 6 (ESE) Earth Sciences and Ecology waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests

3 participants