Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m_map required for testing #4

Closed
mvdh7 opened this issue Jan 8, 2019 · 1 comment
Closed

m_map required for testing #4

mvdh7 opened this issue Jan 8, 2019 · 1 comment

Comments

@mvdh7
Copy link

mvdh7 commented Jan 8, 2019

For JOSS review

The separate package m_map is required to run the example scripts but no information is provided on how to obtain and install this. Consequently I cannot fully test the functional claims of the software.

m_map is also not listed as a requirement in the documentation. If you consider the example scripts to be not part of the software under review then that could perhaps be justified; m_map is not needed to actually execute the main functions. But as the example scripts are the only straightforward way to test the functionality, I'm not sure that that applies in this case.

@ZijieZhaoMMHW
Copy link
Owner

Now it is mentioned and cited in Requirement.

@mvdh7 mvdh7 closed this as completed Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants