Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: A MATLAB toolbox to detect and analyze marine heatwaves #1074

Closed
whedon opened this issue Nov 9, 2018 · 37 comments
Closed

[PRE REVIEW]: A MATLAB toolbox to detect and analyze marine heatwaves #1074

whedon opened this issue Nov 9, 2018 · 37 comments

Comments

@whedon
Copy link

whedon commented Nov 9, 2018

Submitting author: @ZijieZhaoMMHW (Zijie Zhao)
Repository: https://github.com/ZijieZhaoMMHW/m_mhw1.0
Version: v1.0
Editor: @kthyng
Reviewers: @mvdh7

Author instructions

Thanks for submitting your paper to JOSS @ZijieZhaoMMHW. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@ZijieZhaoMMHW if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Nov 9, 2018

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

@whedon
Copy link
Author

whedon commented Nov 9, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 9, 2018

Failed to discover a valid open source license.

@whedon
Copy link
Author

whedon commented Nov 9, 2018

@ZijieZhaoMMHW
Copy link

Hi,

I suggest @fgnievinski to be the reviewer.

@ZijieZhaoMMHW
Copy link

@whedon commands

@whedon
Copy link
Author

whedon commented Nov 9, 2018

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Compile the paper
@whedon generate pdf

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper from a custom git branch
@whedon generate pdf from branch custom-branch-name

@ZijieZhaoMMHW
Copy link

Hi,

I suggest @fgnievinski to be the reviewer.

@ZijieZhaoMMHW
Copy link

Potential reviewers are @fgnievinski and @JesperDramsch if they are ok.

@ZijieZhaoMMHW
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 12, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 12, 2018

@ZijieZhaoMMHW
Copy link

@arfon Sorry to bother. Just notice that it seems that this issue has not been assigned to anyone.... Should I do anything?

@arfon
Copy link
Member

arfon commented Nov 15, 2018

Hi @ZijieZhaoMMHW - I'm currently waiting on an editor to pick up this submission. I'm hoping that one of our MATLAB specialists will be able to handle this submission but they're currently handling a lot of submissions.

Basically, it may take another couple of weeks before this submission will move forward.

@ZijieZhaoMMHW
Copy link

Hi @arfon - Thanks for the response. No worries.

@JesperDramsch
Copy link

Hey folks, I'm not sure I'm up for reviewing this one. I'd like to move away from Matlab as I don't even have the current version installed anymore, or know how package management works. Any way I can adjust my record reflecting this?

@arfon
Copy link
Member

arfon commented Nov 15, 2018

No problem @JesperDramsch - I've removed Matlab from your listed languages here: https://bit.ly/joss-reviewers

@kthyng
Copy link

kthyng commented Nov 18, 2018

Hi @arfon! I don't use Matlab anymore, but I do oceanography. I can edit this if you want.

@arfon
Copy link
Member

arfon commented Nov 18, 2018

Hi @arfon! I don't use Matlab anymore, but I do oceanography. I can edit this if you want.

✨ that would be great. Thanks @kthyng!

@arfon
Copy link
Member

arfon commented Nov 18, 2018

@whedon assign @kthyng as editor

@whedon
Copy link
Author

whedon commented Nov 18, 2018

OK, the editor is @kthyng

@kthyng
Copy link

kthyng commented Nov 18, 2018

Hi @fgnievinski and @mvdh7: are you willing and able to review this JOSS submission? You can read more about the process here. We normally ask for reviews in about 2 weeks but given there is a holiday in the US next week, I would like reviews in the next 3 weeks.

@ZijieZhaoMMHW
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 21, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 21, 2018

@ZijieZhaoMMHW
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 21, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 21, 2018

@kthyng
Copy link

kthyng commented Nov 26, 2018

One more quick ping attempt here.

Hi @fgnievinski and @mvdh7! Are you willing and able to review this JOSS submission? We ask for reviews in about 2 weeks.

@kthyng
Copy link

kthyng commented Dec 3, 2018

Hey @chadagreene! Are you able and willing to review this submission in this next two weeks? I think you'd be a good fit. You can get more info on reviewing here.

@mvdh7
Copy link

mvdh7 commented Dec 3, 2018

Hey, happy to give it a go. Sorry, I haven't had any notifications when you @ me, so I've only just seen this now (thanks to Twitter).

@chadagreene
Copy link

The toolbox looks interesting and nicely documented, but I'm afraid I'm in over my head this month with deadlines, so I must decline. Feel free to ask again in the future.

@kthyng
Copy link

kthyng commented Dec 10, 2018

Ok thanks everyone for their responses, let's go ahead with @mvdh7 as reviewer. I'll set things up to move forward!

@kthyng
Copy link

kthyng commented Dec 10, 2018

@whedon assign @mvdh7 as reviewer

@whedon whedon assigned kthyng and unassigned kthyng Dec 10, 2018
@whedon
Copy link
Author

whedon commented Dec 10, 2018

OK, the reviewer is @mvdh7

@kthyng
Copy link

kthyng commented Dec 10, 2018

@whedon start review

@whedon
Copy link
Author

whedon commented Dec 10, 2018

OK, I've started the review over in #1124. Feel free to close this issue now!

@kthyng kthyng closed this as completed Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants