Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal/coreinternal] Supports pattern for delete and hash actions on attraction #5750

Closed
wants to merge 2 commits into from
Closed

[internal/coreinternal] Supports pattern for delete and hash actions on attraction #5750

wants to merge 2 commits into from

Conversation

sumo-drosiek
Copy link
Member

Description:
Add supportfor pattern configuration for delete and hash actions to attribute attraction

Link to tracking Issue:
N/A

Testing:
unit tests

Documentation:
update README, incode docs

@sumo-drosiek sumo-drosiek requested review from a team and djaglowski October 14, 2021 10:58
bogdandrutu
bogdandrutu requested changes Oct 19, 2021
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@punya please finalize the configuration for "transformation" processors.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 27, 2021
This was referenced Oct 29, 2021
Merged
Closed
@andrzej-stencel
Copy link
Member

@bogdandrutu @punya what's the status here? Is there anything I can help with?

@sumo-drosiek is going on a long PTO; I'd like to make sure this gets merged if possible.

@bogdandrutu bogdandrutu removed the Stale label Oct 29, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 6, 2021
@bogdandrutu bogdandrutu removed the Stale label Nov 12, 2021
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 21, 2021
@pmalek-sumo
Copy link
Contributor

This is not stale. Any chance we can move forward with this? Is there any work we can help with? @punya @bogdandrutu

@punya
Copy link
Member

punya commented Nov 25, 2021

@anuraaga has been working on transformation config DSL.

@github-actions github-actions bot removed the Stale label Nov 29, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 6, 2021
@andrzej-stencel
Copy link
Member

We still don't have a definite answer on what should happen with this proposed change. Should this pull request be closed because there is a conflicting proposed change?

@github-actions github-actions bot removed the Stale label Dec 8, 2021
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 16, 2021
@pmalek-sumo
Copy link
Contributor

Still not stale. @punya @anuraaga any progress with DSL?

Can we help with this perhaps?

@jpkrohling jpkrohling changed the title feat(coreinternal/attraction): supports pattern for delete and hash actions [internal/coreinternal] supports pattern for delete and hash actions on attraction Dec 16, 2021
@jpkrohling jpkrohling changed the title [internal/coreinternal] supports pattern for delete and hash actions on attraction [internal/coreinternal] Supports pattern for delete and hash actions on attraction Dec 16, 2021
@github-actions github-actions bot removed the Stale label Dec 17, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 5, 2022
@jpkrohling jpkrohling removed the Stale label Jan 5, 2022
@jpkrohling
Copy link
Member

@sumo-drosiek, what's the state of this one?

@pmalek-sumo
Copy link
Contributor

@sumo-drosiek, what's the state of this one?

Hi @jpkrohling 👋

@sumo-drosiek is out for the next couple of weeks. The PR seems to have been complete from our PoV but @bogdandrutu commented that there is some work w.r.t DSL which should be used here.

I wanted to bring this subject on Agent's SIG (unfortunately I won't be able to join today though) so that we can pick this up and make some progress.

@jpkrohling
Copy link
Member

That's fine, thanks for the status update.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 20, 2022
@jpkrohling jpkrohling removed the Stale label Jan 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 4, 2022
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Feb 18, 2022
@sumo-drosiek sumo-drosiek mentioned this pull request Apr 1, 2022
Closed
@sumo-drosiek sumo-drosiek mentioned this pull request Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu requested changes

@djaglowski djaglowski Awaiting requested review from djaglowski

Assignees

@djaglowski djaglowski

Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sumo-drosiek @andrzej-stencel @pmalek-sumo @punya @jpkrohling @bogdandrutu @djaglowski