Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(coreinternal/attraction): supports pattern for delete and hash attractions #10822

Merged
merged 6 commits into from
Jul 4, 2022
Merged

feat(coreinternal/attraction): supports pattern for delete and hash attractions #10822

merged 6 commits into from
Jul 4, 2022

Conversation

sumo-drosiek
Copy link
Member

Description:
Add support for pattern configuration for delete and hash actions to attribute attraction

Reopening of #5750 due to inactivity on #8552

Link to tracking Issue:
N/A

Testing:
unit tests

Documentation:
update README, incode docs

@sumo-drosiek sumo-drosiek requested a review from a team June 7, 2022 14:34
@sumo-drosiek sumo-drosiek requested a review from pmm-sumo as a code owner June 7, 2022 14:34
chore(changelog): update
f27b0b3 
Signed-off-by: Dominik Rosiek <[email protected]>
@sumo-drosiek
Copy link
Member Author

Failing test seems to be unrelated:

2022-06-07T14:50:13.7403162Z === RUN   TestRotation/Deletion/ExceedFingerprint/CopyTruncateSequential
2022-06-07T14:50:13.7403708Z     rotation_test.go:292: Potentially unstable ephemerality expectation for test: Deletion/ExceedFingerprint
2022-06-07T14:50:13.7404182Z --- FAIL: TestRotation (5.18s)
2022-06-07T14:50:13.7404651Z     --- PASS: TestRotation/NoRotation/MoveCreateTimestamped (0.22s)
2022-06-07T14:50:13.7405163Z     --- PASS: TestRotation/NoRotation/MoveCreateSequential (0.21s)
2022-06-07T14:50:13.7405838Z     --- PASS: TestRotation/NoRotation/CopyTruncateTimestamped (0.21s)
2022-06-07T14:50:13.7406355Z     --- PASS: TestRotation/NoRotation/CopyTruncateSequential (0.21s)
2022-06-07T14:50:13.7406865Z     --- PASS: TestRotation/NoDeletion/MoveCreateTimestamped (0.23s)
2022-06-07T14:50:13.7407365Z     --- PASS: TestRotation/NoDeletion/MoveCreateSequential (0.24s)
2022-06-07T14:50:13.7407875Z     --- FAIL: TestRotation/NoDeletion/CopyTruncateTimestamped (0.23s)
2022-06-07T14:50:13.7408391Z     --- PASS: TestRotation/NoDeletion/CopyTruncateSequential (0.23s)
2022-06-07T14:50:13.7408897Z     --- PASS: TestRotation/Deletion/MoveCreateTimestamped (0.24s)
2022-06-07T14:50:13.7409395Z     --- PASS: TestRotation/Deletion/MoveCreateSequential (0.24s)
2022-06-07T14:50:13.7409893Z     --- PASS: TestRotation/Deletion/CopyTruncateTimestamped (0.24s)
2022-06-07T14:50:13.7410397Z     --- PASS: TestRotation/Deletion/CopyTruncateSequential (0.24s)
2022-06-07T14:50:13.7410953Z     --- PASS: TestRotation/Deletion/ExceedFingerprint/MoveCreateTimestamped (0.61s)
2022-06-07T14:50:13.7411612Z     --- PASS: TestRotation/Deletion/ExceedFingerprint/MoveCreateSequential (0.58s)
2022-06-07T14:50:13.7412199Z     --- PASS: TestRotation/Deletion/ExceedFingerprint/CopyTruncateTimestamped (0.60s)
2022-06-07T14:50:13.7412837Z     --- PASS: TestRotation/Deletion/ExceedFingerprint/CopyTruncateSequential (0.62s)

@sumo-drosiek sumo-drosiek force-pushed the drosiek-delete-by-pattern branch from 694e589 to f27b0b3 Compare June 9, 2022 06:01
@mx-psi
Copy link
Member

mx-psi commented Jun 28, 2022

@sumo-drosiek can you fix the merge conflicts?

@mx-psi
Copy link
Member

mx-psi commented Jul 1, 2022

The changelog check is failing because the changelog process changed. Could you revert your changes to CHANGELOG.md and follow the instructions there? You may need to create a tracking issue. Thanks!

@sumo-drosiek sumo-drosiek mentioned this pull request Jul 4, 2022
Closed
chore(changelog): update
32b2803 
Signed-off-by: Dominik Rosiek <[email protected]>
@sumo-drosiek
Copy link
Member Author

@mx-psi Done :)

@mx-psi mx-psi linked an issue Jul 4, 2022 that may be closed by this pull request
Supports pattern for delete and hash attractions #11886
Closed
@mx-psi mx-psi merged commit 9a4ab07 into open-telemetry:main Jul 4, 2022
@sumo-drosiek sumo-drosiek deleted the drosiek-delete-by-pattern branch July 4, 2022 10:28
@boostchicken boostchicken mentioned this pull request Jul 12, 2022
Closed
@sumo-drosiek sumo-drosiek mentioned this pull request Mar 28, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmm-sumo pmm-sumo pmm-sumo approved these changes

@mx-psi mx-psi mx-psi approved these changes

Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supports pattern for delete and hash attractions
4 participants
@sumo-drosiek @mx-psi @pmm-sumo @jpkrohling