Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/attributesprocessor] Support regex patterns on DELETE action #8552

Conversation

chris-pinola-rf
Copy link

Description:
As of now, the DELETE action enables users to delete a singular attribute with a well-known name. The current behavior does not help users that need to delete attributes with dynamically named keys (imagine an application that included epoch timestamps in an attribute's name).

This change allows users to specify a pattern on a DELETE action which will be compiled into a regex and used to remove all attributes that match the pattern, via AttributeMap.RemoveIf().

Link to tracking Issue: #8551 #5853

Testing: Tested manually in my local dev environment, still working on adding tests.

Documentation: Will update the relevant docs and example configs once config schema is agreed upon.

@linux-foundation-easycla
Copy link

CLA Not Signed

  • ❌ login: chris-pinola-rf / name: Chris Pinola (a17efff, 75abf1d, 720b132, 5278847). This user is authorized, but they must confirm their affiliation with their company. Start the authorization process by clicking here, click "Corporate",select the appropriate company from the list, then confirm your affiliation on the page that appears. For further assistance with EasyCLA, please submit a support request ticket.

@jpkrohling
Copy link
Member

@boostchicken, could you please review this one?

@pmm-sumo
Copy link
Contributor

Thank you @chris-pinola-rf Could you sign the CLA per the Contributor Guidelines?

@chris-pinola-rf
Copy link
Author

Thank you @chris-pinola-rf Could you sign the CLA per the Contributor Guidelines?

I'm working on getting this squared away with my organization's legal team (we have to appoint a CLA manager), but yes will sign it as soon as I possibly can.

@sumo-drosiek
Copy link
Member

Hi, here is a similar PR: #5750

@chris-pinola-rf Could you compare and incorporate differences (tests, docs)?

@chris-pinola-rf
Copy link
Author

Hi, here is a similar PR: #5750

@chris-pinola-rf Could you compare and incorporate differences (tests, docs)?

@sumo-drosiek Yes, thanks for sharing that. Still working on the legal stuff but making progress.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 16, 2022
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Apr 30, 2022
@sumo-drosiek
Copy link
Member

@chris-pinola-rf Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants