-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/attributesprocessor] Support regex patterns on DELETE action #8552
[processor/attributesprocessor] Support regex patterns on DELETE action #8552
Conversation
|
@boostchicken, could you please review this one? |
Thank you @chris-pinola-rf Could you sign the CLA per the Contributor Guidelines? |
I'm working on getting this squared away with my organization's legal team (we have to appoint a CLA manager), but yes will sign it as soon as I possibly can. |
Hi, here is a similar PR: #5750 @chris-pinola-rf Could you compare and incorporate differences (tests, docs)? |
@sumo-drosiek Yes, thanks for sharing that. Still working on the legal stuff but making progress. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
@chris-pinola-rf Any update on this? |
Description:
As of now, the DELETE action enables users to delete a singular attribute with a well-known name. The current behavior does not help users that need to delete attributes with dynamically named keys (imagine an application that included epoch timestamps in an attribute's name).
This change allows users to specify a
pattern
on a DELETE action which will be compiled into a regex and used to remove all attributes that match the pattern, viaAttributeMap.RemoveIf()
.Link to tracking Issue: #8551 #5853
Testing: Tested manually in my local dev environment, still working on adding tests.
Documentation: Will update the relevant docs and example configs once config schema is agreed upon.