feat(otelcol): do not send pod annotations #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pmalek-sumo
approved these changes
Oct 5, 2021
sumo-drosiek
suggested changes
Oct 6, 2021
sumo-drosiek
approved these changes
Oct 15, 2021
|
I believe the commit from @sumo-drosiek: feat(helm/metadata/otc): drop pod attributes before exporting data relies on this pull request in upstream: open-telemetry/opentelemetry-collector-contrib#5750, which at the moment is still not merged. |
Narrow down the metadata regexes to explicitly only match on pod and namespace labels. This prevents pod annotations from being sent to Sumo, as they all start with `pod_annotations_`.
andrzej-stencel
force-pushed
the
feat-otelcol-do-not-send-pod-annotations
branch
from
fc37d61 to
bfa95f9
Compare
andrzej-stencel
force-pushed
the
feat-otelcol-do-not-send-pod-annotations
branch
from
33e2467 to
a77f54f
Compare
Due to the above, I have decided to extract Dominik's change using the unmerged Otelcol functionality to a separate pull request #1862, so that the original smaller change can be merged without waiting for the upstream merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narrow down the metadata regexes to explicitly only match on pod and namespace labels.
This prevents pod annotations from being sent to Sumo, as they all start with
pod_annotations_.