feat(otelcol): delete pod annotations #1862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narrow down the metadata regexes to explicitly only match on pod and namespace labels. This prevents pod annotations from being sent to Sumo, as they all start with `pod_annotations_`.
Signed-off-by: Dominik Rosiek <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pmalek-sumo
pushed a commit
to SumoLogic/sumologic-otel-collector
that referenced
this pull request
Dec 2, 2021
This PR retrofits upstream PR SumoLogic/sumologic-kubernetes-collection#1862
pmalek-sumo
pushed a commit
to SumoLogic/sumologic-otel-collector
that referenced
this pull request
Dec 2, 2021
This PR retrofits upstream PR SumoLogic/sumologic-kubernetes-collection#1862
pmalek-sumo
pushed a commit
to SumoLogic/sumologic-otel-collector
that referenced
this pull request
Dec 16, 2021
This PR retrofits upstream PR SumoLogic/sumologic-kubernetes-collection#1862
pmalek-sumo
pushed a commit
to SumoLogic/sumologic-otel-collector
that referenced
this pull request
Dec 16, 2021
This PR retrofits upstream PR SumoLogic/sumologic-kubernetes-collection#1862
pmalek-sumo
pushed a commit
to SumoLogic/sumologic-otel-collector
that referenced
this pull request
Dec 16, 2021
This PR retrofits upstream PR SumoLogic/sumologic-kubernetes-collection#1862 * docs(k8sprocessor): add exclude to README * feat(k8sprocessor): remove default exclusion rules
There was a problem hiding this comment.
@astencel-sumo As open-telemetry/opentelemetry-collector-contrib#10822 has been merged we can proceed with this PR
|
Are we sure this is still necessary? It looks like we're dropping the annotations for logs here: That change was made in the following PR: #2251 @sumo-drosiek am I right here? |
|
Yeah, we can close it then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves on #1803 by deleting the annotation attributes before they reach the exporter. This ensures that the annotations are not sent whatever output format is defined in Sumo Logic exporter.
Note that this change uses a functionality in Otel Contrib that is at the moment of writing not merged yet: open-telemetry/opentelemetry-collector-contrib#5750. This change can only be merged when the upstream change is merged and released.