feat(k8sprocessor): add ignored pod names as config parameter #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
force-pushed
the
k8sprocessor-add-ignore-pod-names-as-parameter
branch
from
ca7a45e to
f1650d5
Compare
pmalek-sumo
force-pushed
the
k8sprocessor-add-ignore-pod-names-as-parameter
branch
from
832fc81 to
ced2535
Compare
github-actions
bot
added
the
documentation
pmm-sumo
reviewed
Dec 16, 2021
| @@ -365,3 +365,34 @@ func WithDelimiter(delimiter string) Option { | |||
| return nil | |||
| } | |||
| } | |||
|
|
|||
| var defaultExcludes = ExcludeConfig{ | |||
| Pods: []ExcludePodConfig{ | |||
There was a problem hiding this comment.
As discussed, we could keep the list empty and populate it in Helm chart only for tracing pipeline
pmm-sumo
approved these changes
Dec 16, 2021
This PR retrofits upstream PR SumoLogic/sumologic-kubernetes-collection#1862
pmalek-sumo
force-pushed
the
k8sprocessor-add-ignore-pod-names-as-parameter
branch
from
d1db6ef to
dd2b2d7
Compare
pmalek-sumo
deleted the
k8sprocessor-add-ignore-pod-names-as-parameter
branch
andrzej-stencel
added a commit
that referenced
this pull request
Feb 23, 2022
The issue was fixed in #354
andrzej-stencel
added a commit
that referenced
this pull request
Feb 23, 2022
The issue was fixed in #354
andrzej-stencel
added a commit
that referenced
this pull request
Feb 23, 2022
The issue was fixed in #354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR retrofits upstream PR open-telemetry/opentelemetry-collector-contrib#3520