Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata for pods with specific names is not added #334

Closed
kasia-kujawa opened this issue Nov 10, 2021 · 2 comments · Fixed by #354
Closed

Metadata for pods with specific names is not added #334

kasia-kujawa opened this issue Nov 10, 2021 · 2 comments · Fixed by #354
Assignees
Labels
bug Something isn't working

Comments

@kasia-kujawa
Copy link
Contributor

kasia-kujawa commented Nov 10, 2021

Metadata for pods with specific names is not added by k8sprocessor

For example when pod name is collection-sumologic-otelcol-logs-1 then some metadata (e.g. statefulset) are not available in Sumo.

There is constant list of pod names patterns to ignore, see this:

	// TODO: move these to config with default values
	podNameIgnorePatterns = []*regexp.Regexp{
		regexp.MustCompile(`jaeger-agent`),
		regexp.MustCompile(`jaeger-collector`),
		regexp.MustCompile(`otel-collector`),
		regexp.MustCompile(`otel-agent`),
		regexp.MustCompile(`collection-sumologic-otelcol`),
	}

and podNameIgnorePatterns is used in shouldIgnorePod see here.

@kasia-kujawa kasia-kujawa added the bug Something isn't working label Nov 10, 2021
@kasia-kujawa
Copy link
Contributor Author

In upstream version of the plugin list of pod names patterns to ignore is configurable open-telemetry/opentelemetry-collector-contrib#3520

@kasia-kujawa kasia-kujawa changed the title Metadata for pods with specific names are not added Metadata for pods with specific names is not added Nov 17, 2021
kasia-kujawa added a commit that referenced this issue Nov 17, 2021
add information about issue with missing metadata for Pods with specific names (#334)
kasia-kujawa added a commit that referenced this issue Nov 17, 2021
add information about issue with missing metadata for Pods with specific names (#334)
@pmalek-sumo
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants