-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: on page reload Insights page redirecting to Dashboard #1517
Merged
brandonroberts
merged 1 commit into
open-sauced:beta
from
deepakrudrapaul:fix-insight-page-refresh-issue
Aug 8, 2023
Merged
fix: on page reload Insights page redirecting to Dashboard #1517
brandonroberts
merged 1 commit into
open-sauced:beta
from
deepakrudrapaul:fix-insight-page-refresh-issue
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
β Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
deepakrudrapaul
force-pushed
the
fix-insight-page-refresh-issue
branch
from
August 7, 2023 20:10
fcb24ec
to
404749e
Compare
bdougie
approved these changes
Aug 7, 2023
NsdHSO
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
brandonroberts
approved these changes
Aug 8, 2023
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
## [1.59.0](v1.58.0...v1.59.0) (2023-08-08) ### π§βπ» Code Refactoring * replace supabase/ui in design system typography components ([#1438](#1438)) ([38cfb30](38cfb30)) ### π Features * add a user notifications page ([#1478](#1478)) ([022dc69](022dc69)) * add conditional routing to single highlight dialog close action ([#1473](#1473)) ([1341cba](1341cba)) * add github link to profile ([#1459](#1459)) ([d42bc6d](d42bc6d)) * add support for highlight.new ([#1487](#1487)) ([3daa5c0](3daa5c0)) * improved the UX on the feeds page and scroll behaviour ([#1506](#1506)) ([31c1593](31c1593)) * onboarding auto fetch timezone ([#1488](#1488)) ([ae5cdd7](ae5cdd7)) ### π Bug Fixes * Feed page responsiveness ([#1490](#1490)) ([67662b2](67662b2)) * feeds page typography and styles improvements ([#1467](#1467)) ([a3b289e](a3b289e)) * on page reload Insights page redirecting to Dashboard ([#1517](#1517)) ([397c36e](397c36e)) * update environment variable for Sentry ([#1521](#1521)) ([56ac14b](56ac14b)) * update release workflow to use GitHub app for semantic versioning ([#1484](#1484)) ([3f1ce84](3f1ce84)) * update user interest logo error for machine learning ([#1474](#1474)) ([a286eda](a286eda)) * uses session to update user info for notifications check ([#1486](#1486)) ([60d787e](60d787e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Insights page redirecting to Dashboard on page reload.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #1503
Mobile & Desktop Screenshots/Recordings
Before :
After :
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
π