Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feeds page typography and styles improvements #1467

Merged
merged 5 commits into from
Aug 4, 2023

Conversation

OgDev-01
Copy link
Contributor

@OgDev-01 OgDev-01 commented Aug 2, 2023

Description

This PR fixes general style inconsistency on the feeds page. The changes are not easily noticeable. You can get more context on what has changed here

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #1465

Mobile & Desktop Screenshots/Recordings

Before

image

After

image

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit d5378e3
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/64ca73fd75d6990007df674a
😎 Deploy Preview https://deploy-preview-1467--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit d5378e3
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/64ca73fde7f41200082778ae
😎 Deploy Preview https://deploy-preview-1467--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OgDev-01 OgDev-01 added the needs review PRs that need review from core engineering team label Aug 2, 2023
@isabensusan
Copy link
Member

We just went through this, but wanted to leave it in writing :)

  1. can we match the width of the top panel with the bottom panel? so everything looks the same width
image
  1. Double check that all panel titles have the same font-size and font-weight -- I think the "Repositories" title doesn't match the rest. Same with subtitles

  2. Can we make the highlight links have regular font-weight instead of bold or semibold?

image

@OgDev-01
Copy link
Contributor Author

OgDev-01 commented Aug 2, 2023

Done @isabensusan 👍

Copy link
Contributor

@babblebey babblebey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍕

@OgDev-01 OgDev-01 merged commit a3b289e into beta Aug 4, 2023
@OgDev-01 OgDev-01 deleted the 1465-feeds-style-fix branch August 4, 2023 00:44
github-actions bot pushed a commit that referenced this pull request Aug 4, 2023
## [1.59.0-beta.2](v1.59.0-beta.1...v1.59.0-beta.2) (2023-08-04)

### 🐛 Bug Fixes

* feeds page typography and styles improvements ([#1467](#1467)) ([a3b289e](a3b289e))
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

🎉 This PR is included in version 1.59.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

open-sauced bot pushed a commit that referenced this pull request Aug 8, 2023
## [1.59.0](v1.58.0...v1.59.0) (2023-08-08)

### 🧑‍💻 Code Refactoring

* replace supabase/ui in design system typography components ([#1438](#1438)) ([38cfb30](38cfb30))

### 🍕 Features

* add a user notifications page ([#1478](#1478)) ([022dc69](022dc69))
* add conditional routing to single highlight dialog close action ([#1473](#1473)) ([1341cba](1341cba))
* add github link to profile ([#1459](#1459)) ([d42bc6d](d42bc6d))
* add support for highlight.new ([#1487](#1487)) ([3daa5c0](3daa5c0))
* improved the UX on the feeds page and scroll behaviour ([#1506](#1506)) ([31c1593](31c1593))
* onboarding auto fetch timezone ([#1488](#1488)) ([ae5cdd7](ae5cdd7))

### 🐛 Bug Fixes

* Feed page responsiveness  ([#1490](#1490)) ([67662b2](67662b2))
* feeds page typography and styles improvements ([#1467](#1467)) ([a3b289e](a3b289e))
* on page reload Insights page redirecting to Dashboard ([#1517](#1517)) ([397c36e](397c36e))
* update environment variable for Sentry ([#1521](#1521)) ([56ac14b](56ac14b))
* update release workflow to use GitHub app for semantic versioning ([#1484](#1484)) ([3f1ce84](3f1ce84))
* update user interest logo error for machine learning ([#1474](#1474)) ([a286eda](a286eda))
* uses session to update user info for notifications check ([#1486](#1486)) ([60d787e](60d787e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review PRs that need review from core engineering team released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Typography is off in Highlights page
5 participants