-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace supabase/ui in design system typography components #1438
refactor: replace supabase/ui in design system typography components #1438
Conversation
…hy-component-in-design-system
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ps://github.com/babblebey/insights into refactor/typography-components-in-design-system
…ps://github.com/babblebey/insights into refactor/typography-components-in-design-system
Hey @babblebey, is this ready for review? |
@OgDev-01.... In a bit 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Watched Files
This pull request modifies specific files that require careful review by the maintainers.
Files Matched
- npm-shrinkwrap.json
- package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... Thanks for taking a step forward and adding the tailwinds typography plugin 🍕
Quite a well crafted novel on the typography-wrapper
story though 😁
## [1.59.0-beta.3](v1.59.0-beta.2...v1.59.0-beta.3) (2023-08-04) ### 🧑💻 Code Refactoring * replace supabase/ui in design system typography components ([#1438](#1438)) ([38cfb30](38cfb30)) ### 🐛 Bug Fixes * update release workflow to use GitHub app for semantic versioning ([#1484](#1484)) ([3f1ce84](3f1ce84))
## [1.59.0](v1.58.0...v1.59.0) (2023-08-08) ### 🧑💻 Code Refactoring * replace supabase/ui in design system typography components ([#1438](#1438)) ([38cfb30](38cfb30)) ### 🍕 Features * add a user notifications page ([#1478](#1478)) ([022dc69](022dc69)) * add conditional routing to single highlight dialog close action ([#1473](#1473)) ([1341cba](1341cba)) * add github link to profile ([#1459](#1459)) ([d42bc6d](d42bc6d)) * add support for highlight.new ([#1487](#1487)) ([3daa5c0](3daa5c0)) * improved the UX on the feeds page and scroll behaviour ([#1506](#1506)) ([31c1593](31c1593)) * onboarding auto fetch timezone ([#1488](#1488)) ([ae5cdd7](ae5cdd7)) ### 🐛 Bug Fixes * Feed page responsiveness ([#1490](#1490)) ([67662b2](67662b2)) * feeds page typography and styles improvements ([#1467](#1467)) ([a3b289e](a3b289e)) * on page reload Insights page redirecting to Dashboard ([#1517](#1517)) ([397c36e](397c36e)) * update environment variable for Sentry ([#1521](#1521)) ([56ac14b](56ac14b)) * update release workflow to use GitHub app for semantic versioning ([#1484](#1484)) ([3f1ce84](3f1ce84)) * update user interest logo error for machine learning ([#1474](#1474)) ([a286eda](a286eda)) * uses session to update user info for notifications check ([#1486](#1486)) ([60d787e](60d787e))
Description
This pull request aims to refactor the typography components (
Title
andText
) in the design system to improve consistency, maintainability, and extensibility. The changes in this branch replacessupabase/ui
typography component with nativehtml
alternatives leveraging@tailwindcss/typography
and introduce enhancements to provide flexibility.Notable Change
Introduce the
TypographyWrapper
componentThis component serves as a wrapper around child components exposing
children
components to theprose
utility class from@tailwindcss/typography
which adds beautiful typographic defaults to uncontrollable vanilla HTML, like HTML rendered from Markdown.It also serves as a primary wrapper for the
Title
andText
components.Implementation
The Component accepts the
className
andsize
props which uses as/to modify the belowclass
es for the returned element"prose"
: This is a default CSS class that provides basic typographic styles, such as margins and line heights, to improve readability of the text."prose-${size}"
: This class is dynamically generated based on thesize
prop. For example, if size is set to "sm", it will apply the class "prose-sm", which provides smaller font size and line height. Similarly, for other size values, appropriate styles will be applied.className
: This is used to apply any additional CSS classes passed through theclassName
prop.The component also passes any other props that might be provided to the
TypographyWrapper
through the...props
spread operator. This allows developers to use additional attributes on the wrapper element.Use Cases
Title
components.Blogposts
highlight type 🍕)Other Changes
Text
component very much follows similar implementation and integrates exactly as that in the initial set-up without regression.Title
component also follows similar implementation and integrates exactly as that in the initial set-up.What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #1133
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
Install
@tailwindcss/typography
for local development[optional] What gif best describes this PR or how it makes you feel?