Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user interest logo error #1474

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

anubhav1206
Copy link
Contributor

@anubhav1206 anubhav1206 commented Aug 3, 2023

Description

fixed #1469

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Aug 3, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 29740bf
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/64cb5cbe3dd27c00085b6afb
😎 Deploy Preview https://deploy-preview-1474--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 3, 2023

βœ… Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 29740bf
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/64cb5cbed435a90008abca29
😎 Deploy Preview https://deploy-preview-1474--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "beta" branch. This is described in our Contributing Guide. We would suggest that you close this PR and implement your changes as described in our Contributing Guide and open a new pull request.

@anubhav1206 anubhav1206 changed the title fixed the "logo is not displaying" bug #1469 fix: addressed the "logo is not displaying" bug #1469 Aug 3, 2023
@OgDev-01
Copy link
Contributor

OgDev-01 commented Aug 3, 2023

Hey @anubhav1206, Thanks for this quick fix... Can you go through this quickly and link the related issue to this PR

@anubhav1206
Copy link
Contributor Author

Hey @anubhav1206, Thanks for this quick fix... Can you go through this quickly and link the related issue to this PR

sure

@anubhav1206
Copy link
Contributor Author

Hey @anubhav1206, Thanks for this quick fix... Can you go through this quickly and link the related issue to this PR

done

Copy link
Contributor

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ•

@OgDev-01 OgDev-01 changed the title fix: addressed the "logo is not displaying" bug #1469 fix: user interest logo error Aug 3, 2023
@OgDev-01 OgDev-01 added the needs review PRs that need review from core engineering team label Aug 3, 2023
@OgDev-01 OgDev-01 requested a review from bdougie August 3, 2023 13:11
@OgDev-01
Copy link
Contributor

OgDev-01 commented Aug 3, 2023

Just a side note: It's good practice to add a brief description and screenshots/records(if changes are visually seen) of what was done in the PR before and after. This helps for future references and a quicker review πŸ•

@brandonroberts brandonroberts merged commit a286eda into open-sauced:beta Aug 3, 2023
github-actions bot pushed a commit that referenced this pull request Aug 3, 2023
## [1.59.0-beta.1](v1.58.0...v1.59.0-beta.1) (2023-08-03)

### πŸ› Bug Fixes

* update user interest logo error for machine learning ([#1474](#1474)) ([a286eda](a286eda))

### πŸ• Features

* add conditional routing to single highlight dialog close action ([#1473](#1473)) ([1341cba](1341cba))
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

πŸŽ‰ This PR is included in version 1.59.0-beta.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

open-sauced bot pushed a commit that referenced this pull request Aug 8, 2023
## [1.59.0](v1.58.0...v1.59.0) (2023-08-08)

### πŸ§‘β€πŸ’» Code Refactoring

* replace supabase/ui in design system typography components ([#1438](#1438)) ([38cfb30](38cfb30))

### πŸ• Features

* add a user notifications page ([#1478](#1478)) ([022dc69](022dc69))
* add conditional routing to single highlight dialog close action ([#1473](#1473)) ([1341cba](1341cba))
* add github link to profile ([#1459](#1459)) ([d42bc6d](d42bc6d))
* add support for highlight.new ([#1487](#1487)) ([3daa5c0](3daa5c0))
* improved the UX on the feeds page and scroll behaviour ([#1506](#1506)) ([31c1593](31c1593))
* onboarding auto fetch timezone ([#1488](#1488)) ([ae5cdd7](ae5cdd7))

### πŸ› Bug Fixes

* Feed page responsiveness  ([#1490](#1490)) ([67662b2](67662b2))
* feeds page typography and styles improvements ([#1467](#1467)) ([a3b289e](a3b289e))
* on page reload Insights page redirecting to Dashboard ([#1517](#1517)) ([397c36e](397c36e))
* update environment variable for Sentry ([#1521](#1521)) ([56ac14b](56ac14b))
* update release workflow to use GitHub app for semantic versioning ([#1484](#1484)) ([3f1ce84](3f1ce84))
* update user interest logo error for machine learning ([#1474](#1474)) ([a286eda](a286eda))
* uses session to update user info for notifications check ([#1486](#1486)) ([60d787e](60d787e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review PRs that need review from core engineering team released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: AI and Machine Learning logo is not displaying in current interest
3 participants