feat: add a notifications page #1478

takanome-dev · 2023-08-03T20:34:51Z

Description

This pr adds a notifications page to show all the user notifications paginated.

add a new notifications page
display notifications with paginations
filter notifications by type
remove the notification dropdown and link to this page
should only be accessible by the current logged in user

What type of PR is this? (check all applicable)

Related Tickets & Documents

Fixes #1444

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2023-08-03T20:34:57Z

✅ Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`e61d9f6`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/64d11800c1f9790007d89983
😎 Deploy Preview	https://deploy-preview-1478--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-08-03T20:34:59Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`e61d9f6`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/64d118004cc4d70008f8f8d5
😎 Deploy Preview	https://deploy-preview-1478--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

takanome-dev · 2023-08-03T20:40:25Z

cc @bdougie @OgDev-01 @brandonroberts feedback is welcome 🙏

bdougie · 2023-08-03T20:46:46Z

UI is great. I think this leans into our design system well. I let others review the code more closely, but QA wise it works. Navigating here, I think we should have a "view all notifications" link and limit how many we show.

notifications dropdown

We can remove the dropdown and take the user to this page instead. I don't think there is value for having the dropdown anymore with this new page.

takanome-dev · 2023-08-03T22:05:22Z

UI is great. I think this leans into our design system well. I let others review the code more closely, but QA wise it works. Navigating here, I think we should have a "view all notifications" link and limit how many we show.

I hardcoded the limit to be 10 and there is pagination.

Q. Where should I put the view all notifications link?

bdougie · 2023-08-03T22:12:19Z

Q. Where should I put the view all notifications link?

When you click the notification bell, that is the link. No more dropdown.

brandonroberts · 2023-08-04T14:45:54Z

@takanome-dev nice work! These should be listed by most recent first. May need an API update on that also

takanome-dev · 2023-08-04T16:44:00Z

These should be listed by most recent first. May need an API update on that also

That's right, how about sorting them before rendering for now?

brandonroberts · 2023-08-04T18:41:22Z

These should be listed by most recent first. May need an API update on that also

That's right, how about sorting them before rendering for now?

That works for now

brandonroberts · 2023-08-04T18:42:43Z

@takanome-dev I propose changing the path to /user/notifications because its an authenticated route. You can't visit notifications for other users. It will likely simplify some of the middleware logic added also

pages/user/[username]/notifications.tsx

bdougie

Made some grammar fixes. For now this works as is, there will be adjustments in the design and UI in the future.

pages/user/[username]/notifications.tsx

bdougie

Need a test for the new lib function.

lib/utils/get-notification-url.ts

Co-authored-by: Brandon Roberts <[email protected]>

Co-authored-by: Olabode Lawal-Shittabey <[email protected]>

takanome-dev · 2023-08-05T11:51:34Z

but It didn't look like you implemented it yet, so I thought the Layout could be the ProfileLayout hence my suggestions!?

Yo I totally forgot about the footer, thanks for noticing 👍

pages/user/notifications.tsx

babblebey · 2023-08-06T15:11:24Z

Yo I totally forgot about the footer, thanks for noticing 👍

🍕

CHANGELOG.md

middleware.ts

brandonroberts · 2023-08-07T15:31:36Z

@takanome-dev the changelog updates are still present

takanome-dev · 2023-08-07T15:57:45Z

@takanome-dev the changelog updates are still present

@brandonroberts I need help here 😅 git checkout -- CHANGELOG.md didn't revert it. I also tried git checkout upstream/beta -- CHANGELOG.md but I see new changes. What I'm missing?

brandonroberts · 2023-08-07T16:10:14Z

@takanome-dev try using the current file contents from beta, using git add . and git commit --no-verify to skip the hooks so it doesn't get formatted again

takanome-dev · 2023-08-07T16:14:22Z

@takanome-dev try using the current file contents from beta, using git add . and git commit --no-verify to skip the hooks so it doesn't get formatted again

It worked, thanks 👍

brandonroberts · 2023-08-08T13:33:40Z

@takanome-dev Thanks!

## [1.59.0-beta.7](v1.59.0-beta.6...v1.59.0-beta.7) (2023-08-08) ### 🐛 Bug Fixes * on page reload Insights page redirecting to Dashboard ([#1517](#1517)) ([397c36e](397c36e)) ### 🍕 Features * add a user notifications page ([#1478](#1478)) ([022dc69](022dc69))

## [1.59.0](v1.58.0...v1.59.0) (2023-08-08) ### 🧑‍💻 Code Refactoring * replace supabase/ui in design system typography components ([#1438](#1438)) ([38cfb30](38cfb30)) ### 🍕 Features * add a user notifications page ([#1478](#1478)) ([022dc69](022dc69)) * add conditional routing to single highlight dialog close action ([#1473](#1473)) ([1341cba](1341cba)) * add github link to profile ([#1459](#1459)) ([d42bc6d](d42bc6d)) * add support for highlight.new ([#1487](#1487)) ([3daa5c0](3daa5c0)) * improved the UX on the feeds page and scroll behaviour ([#1506](#1506)) ([31c1593](31c1593)) * onboarding auto fetch timezone ([#1488](#1488)) ([ae5cdd7](ae5cdd7)) ### 🐛 Bug Fixes * Feed page responsiveness ([#1490](#1490)) ([67662b2](67662b2)) * feeds page typography and styles improvements ([#1467](#1467)) ([a3b289e](a3b289e)) * on page reload Insights page redirecting to Dashboard ([#1517](#1517)) ([397c36e](397c36e)) * update environment variable for Sentry ([#1521](#1521)) ([56ac14b](56ac14b)) * update release workflow to use GitHub app for semantic versioning ([#1484](#1484)) ([3f1ce84](3f1ce84)) * update user interest logo error for machine learning ([#1474](#1474)) ([a286eda](a286eda)) * uses session to update user info for notifications check ([#1486](#1486)) ([60d787e](60d787e))

feat: add a notifications page

dec2178

remove notification dropdown

7f1fa52

takanome-dev added 2 commits August 4, 2023 18:29

redirect user if they try to access other user's notifications

a6409cc

fix merge conflicts

a905778

takanome-dev marked this pull request as ready for review August 4, 2023 18:32

takanome-dev requested review from OgDev-01 and brandonroberts August 4, 2023 18:38

takanome-dev added the needs review PRs that need review from core engineering team label Aug 4, 2023

bdougie reviewed Aug 4, 2023

View reviewed changes

pages/user/[username]/notifications.tsx Outdated Show resolved Hide resolved

bdougie reviewed Aug 4, 2023

View reviewed changes

pages/user/[username]/notifications.tsx Outdated Show resolved Hide resolved

brandonroberts added requested changes and removed needs review PRs that need review from core engineering team labels Aug 4, 2023

bdougie added 2 commits August 4, 2023 11:47

Update pages/user/[username]/notifications.tsx

cc4e483

Update pages/user/[username]/notifications.tsx

a34f58d

bdougie approved these changes Aug 4, 2023

View reviewed changes

brandonroberts reviewed Aug 4, 2023

View reviewed changes

pages/user/[username]/notifications.tsx Outdated Show resolved Hide resolved

bdougie requested changes Aug 4, 2023

View reviewed changes

lib/utils/get-notification-url.ts Outdated Show resolved Hide resolved

takanome-dev and others added 3 commits August 4, 2023 18:50

Update pages/user/[username]/notifications.tsx

aaae34d

Co-authored-by: Brandon Roberts <[email protected]>

update notifications path and middleware

74eaeeb

add test for get notifications function

5076a55

takanome-dev and others added 4 commits August 5, 2023 11:39

import profile layout

0dd1738

Co-authored-by: Olabode Lawal-Shittabey <[email protected]>

redirect to feed for unauthed users

cdfbf6e

remove top nav and use profile layout

197273e

fix merge conflicts

e6e9d70

bdougie reviewed Aug 5, 2023

View reviewed changes

pages/user/notifications.tsx Outdated Show resolved Hide resolved

Update pages/user/notifications.tsx

80184f4

bdougie reviewed Aug 5, 2023

View reviewed changes

pages/user/notifications.tsx Outdated Show resolved Hide resolved

Update pages/user/notifications.tsx

24e4323

bdougie approved these changes Aug 5, 2023

View reviewed changes

brandonroberts requested changes Aug 7, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

middleware.ts Outdated Show resolved Hide resolved

revert unnecessary changes

7dcfac9

takanome-dev requested a review from brandonroberts August 7, 2023 14:54

revert changelog

16d2e72

brandonroberts added requested changes and removed needs review PRs that need review from core engineering team labels Aug 7, 2023

this should revert it right?

74b7b67

revert changelog and skip precommit hooks

e61d9f6

brandonroberts approved these changes Aug 8, 2023

View reviewed changes

brandonroberts merged commit 022dc69 into open-sauced:beta Aug 8, 2023

takanome-dev deleted the 1444-show-all-notifications branch August 8, 2023 20:39

takanome-dev mentioned this pull request Aug 9, 2023

fix: long names spacing in top contributors card #1520

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add a notifications page #1478

feat: add a notifications page #1478

takanome-dev commented Aug 3, 2023 •

edited

Loading

netlify bot commented Aug 3, 2023 •

edited

Loading

netlify bot commented Aug 3, 2023 •

edited

Loading

takanome-dev commented Aug 3, 2023

bdougie commented Aug 3, 2023 •

edited

Loading

takanome-dev commented Aug 3, 2023

bdougie commented Aug 3, 2023 •

edited

Loading

brandonroberts commented Aug 4, 2023

takanome-dev commented Aug 4, 2023

brandonroberts commented Aug 4, 2023

brandonroberts commented Aug 4, 2023 •

edited

Loading

bdougie left a comment

bdougie left a comment

takanome-dev commented Aug 5, 2023

babblebey commented Aug 6, 2023

brandonroberts commented Aug 7, 2023

takanome-dev commented Aug 7, 2023

brandonroberts commented Aug 7, 2023

takanome-dev commented Aug 7, 2023

brandonroberts commented Aug 8, 2023

feat: add a notifications page #1478

feat: add a notifications page #1478

Conversation

takanome-dev commented Aug 3, 2023 • edited Loading

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Aug 3, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

netlify bot commented Aug 3, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

takanome-dev commented Aug 3, 2023

bdougie commented Aug 3, 2023 • edited Loading

notifications dropdown

takanome-dev commented Aug 3, 2023

bdougie commented Aug 3, 2023 • edited Loading

brandonroberts commented Aug 4, 2023

takanome-dev commented Aug 4, 2023

brandonroberts commented Aug 4, 2023

brandonroberts commented Aug 4, 2023 • edited Loading

bdougie left a comment

Choose a reason for hiding this comment

bdougie left a comment

Choose a reason for hiding this comment

takanome-dev commented Aug 5, 2023

babblebey commented Aug 6, 2023

brandonroberts commented Aug 7, 2023

takanome-dev commented Aug 7, 2023

brandonroberts commented Aug 7, 2023

takanome-dev commented Aug 7, 2023

brandonroberts commented Aug 8, 2023

takanome-dev commented Aug 3, 2023 •

edited

Loading

netlify bot commented Aug 3, 2023 •

edited

Loading

netlify bot commented Aug 3, 2023 •

edited

Loading

bdougie commented Aug 3, 2023 •

edited

Loading

bdougie commented Aug 3, 2023 •

edited

Loading

brandonroberts commented Aug 4, 2023 •

edited

Loading