Network: don't enable TLS when not configured #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig TLS properties
reinkrul
requested review from
gerardsn and
woutslakhorst
and removed request for
gerardsn
woutslakhorst
approved these changes
Mar 6, 2024
rolandgroen
added a commit
that referenced
this pull request
Mar 8, 2024
* master: (40 commits) Bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3 (#2889) StatusList2021: add e2e test (#2881) remove default storage backend (#2885) Bump github.com/lestrrat-go/jwx/v2 from 2.0.20 to 2.0.21 (#2887) SQL: Rename table vdr_didweb to did (#2882) VDR: Replace v2 API panics with errors (#2872) Network: don't enable TLS when not configured (#2877) Statuslist: Merge issuer and verifier (#2851) revert go-version to stable (#2879) set column length for did and id (#2878) Bump golang from 1.22.0-alpine to 1.22.1-alpine (#2876) Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#2875) Docker: drop 'v' prefix from versions (#2855) Upgrade to go 1.22 (#2862) Bump google.golang.org/grpc from 1.62.0 to 1.62.1 (#2874) Bump golang.org/x/crypto from 0.20.0 to 0.21.0 (#2859) HTTP: correct status code logging for errors (#2848) IAM: Handle ErrNotFound for unknown tokens when introspecting (#2847) Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#2849) allow for empty VPs (#2840) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
network.enabletls, which was used in demo/workshop environments. But running without TLS will now also be useful when a node only usesdid:web, and having to disable a Network property is inconvenient then.So, with this change TLS won't be enabled when it's not configured. TLS must be enabled when:
Also removes deprecated config TLS properties.
Fixes #2864