Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Rename table vdr_didweb to did #2882

Merged
merged 2 commits into from
Mar 7, 2024
Merged

SQL: Rename table vdr_didweb to did #2882

merged 2 commits into from
Mar 7, 2024

Conversation

reinkrul
Copy link
Member

@reinkrul reinkrul commented Mar 7, 2024

Fixes #2861

gerardsn
gerardsn requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the migration file names still contain didweb, and did:web occurs several times in the migration files comments

IMO merging migrations files 003 and 005 makes sense, but probably fine as is

storage/test.go Show resolved Hide resolved
@reinkrul reinkrul requested a review from gerardsn March 7, 2024 11:14
@reinkrul reinkrul merged commit 171ab14 into master Mar 7, 2024
9 checks passed
@reinkrul reinkrul deleted the sql/rename_did_table branch March 7, 2024 12:25
rolandgroen added a commit that referenced this pull request Mar 8, 2024
@rolandgroen
Merge branch 'master' into fix/2755
20a7779 
* master: (40 commits)
  Bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3 (#2889)
  StatusList2021: add e2e test (#2881)
  remove default storage backend (#2885)
  Bump github.com/lestrrat-go/jwx/v2 from 2.0.20 to 2.0.21 (#2887)
  SQL: Rename table vdr_didweb to did (#2882)
  VDR: Replace v2 API panics with errors (#2872)
  Network: don't enable TLS when not configured (#2877)
  Statuslist: Merge issuer and verifier (#2851)
  revert go-version to stable (#2879)
  set column length for did and id (#2878)
  Bump golang from 1.22.0-alpine to 1.22.1-alpine (#2876)
  Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#2875)
  Docker: drop 'v' prefix from versions (#2855)
  Upgrade to go 1.22 (#2862)
  Bump google.golang.org/grpc from 1.62.0 to 1.62.1 (#2874)
  Bump golang.org/x/crypto from 0.20.0 to 0.21.0 (#2859)
  HTTP: correct status code logging for errors (#2848)
  IAM: Handle ErrNotFound for unknown tokens when introspecting (#2847)
  Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#2849)
  allow for empty VPs (#2840)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerardsn gerardsn gerardsn approved these changes

@woutslakhorst woutslakhorst Awaiting requested review from woutslakhorst woutslakhorst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL: Rename vdr_didweb table to did
2 participants
@reinkrul @gerardsn