Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: drop 'v' prefix from versions #2855

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

gerardsn
Copy link
Member

@gerardsn gerardsn commented Mar 4, 2024

closes #1629

this drops the tag v prefix for docker images, so tag v6.0.0 creates docker image nutsfoundation/nuts-node:6.0.0

it also removes the major version tag (nutsfoundation/nuts-node:6). This is currently broken as tagging 6.0.1 will set this version as 6, even if tag 6.1.0 already exists.

Maybe wait to merge this until we are sure there will not be a v5.5.*

@woutslakhorst
Copy link
Member

Maybe wait to merge this until we are sure there will not be a v5.5.*

v5.5 should branch somewhere from v5

@reinkrul
Copy link
Member

reinkrul commented Mar 5, 2024

Let's wait with merging until we decided what versions we are going to release with what functionality.

Update: we decided on master -> v6, so can be merged.

@reinkrul
Copy link
Member

reinkrul commented Mar 6, 2024

Maybe wait to merge this until we are sure there will not be a v5.5.*

v5.5 should branch somewhere from v5

From v5.4 then

@gerardsn gerardsn merged commit 2aa7688 into master Mar 6, 2024
9 checks passed
@gerardsn gerardsn deleted the docker/drop-version-prefix-v branch March 6, 2024 13:00
rolandgroen added a commit that referenced this pull request Mar 8, 2024
* master: (40 commits)
  Bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3 (#2889)
  StatusList2021: add e2e test (#2881)
  remove default storage backend (#2885)
  Bump github.com/lestrrat-go/jwx/v2 from 2.0.20 to 2.0.21 (#2887)
  SQL: Rename table vdr_didweb to did (#2882)
  VDR: Replace v2 API panics with errors (#2872)
  Network: don't enable TLS when not configured (#2877)
  Statuslist: Merge issuer and verifier (#2851)
  revert go-version to stable (#2879)
  set column length for did and id (#2878)
  Bump golang from 1.22.0-alpine to 1.22.1-alpine (#2876)
  Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#2875)
  Docker: drop 'v' prefix from versions (#2855)
  Upgrade to go 1.22 (#2862)
  Bump google.golang.org/grpc from 1.62.0 to 1.62.1 (#2874)
  Bump golang.org/x/crypto from 0.20.0 to 0.21.0 (#2859)
  HTTP: correct status code logging for errors (#2848)
  IAM: Handle ErrNotFound for unknown tokens when introspecting (#2847)
  Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#2849)
  allow for empty VPs (#2840)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker: inconsistent tagging
3 participants