Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network: fail to start if deprecated TLS config is present #2909

Closed
gerardsn opened this issue Mar 13, 2024 · 0 comments · Fixed by #2913
Closed

Network: fail to start if deprecated TLS config is present #2909

gerardsn opened this issue Mar 13, 2024 · 0 comments · Fixed by #2913
Assignees
Labels
Milestone

Comments

@gerardsn
Copy link
Member

gerardsn commented Mar 13, 2024

#2877 removed the deprecated TLS config under network (moved to tls) i.e.,

strictmode: false
network:
  truststorefile: /ssl/truststore.pem
  certfile: /ssl/certificate.pem
  certkeyfile: /ssl/certificate.pem
  grpcaddr:  :5555

As this is no longer parsed, nodes using this config now try to connect to peers without TLS. This obviously fails, but the message is extremely unhelpful:

2024-03-13 11:22:56 time="2024-03-13T10:22:56Z" level=debug msg="failed to open a grpc ClientConn" error="context deadline exceeded: connection error: desc = \"error reading server preface: http2: frame too large\"" module=Network peerAddr=<rein> peerAuthenticated=false peerDID= peerID=
2024-03-13 11:22:56 time="2024-03-13T10:22:56Z" level=debug msg="failed to open a grpc ClientConn" error="context deadline exceeded: connection error: desc = \"error reading server preface: EOF\"" module=Network peerAddr=<wout> peerAuthenticated=false peerDID= peerID=
2024-03-13 11:22:56 time="2024-03-13T10:22:56Z" level=debug msg="failed to open a grpc ClientConn" error="context deadline exceeded: connection error: desc = \"error reading server preface: EOF\"" module=Network peerAddr=<gerard> peerAuthenticated=false peerDID= peerID=
2024-03-13 11:22:57 time="2024-03-13T10:22:57Z" level=debug msg="failed to open a grpc ClientConn" error="context deadline exceeded: connection error: desc = \"error reading server preface: http2: frame too large\"" module=Network peerAddr=<e-care> peerAuthenticated=false peerDID= peerID=

Solution: A node should fail to start if the deprecated config settings are present

(Nodes not wanting to use TLS still works fine as demonstrated by e2e tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant