Fail to start when deprecated network params are used #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinkrul
reviewed
Mar 14, 2024
|
I was thinking only for this case since it took me a couple of hours to figure out what caused this to fail. User trying to upgrade are going to be very frustrated if they have to go through the same proces. A better option imo would be to fail (maybe just in production) if the config contains invalid parameters, but I don't know if this is possible/desirable. |
reinkrul
approved these changes
Mar 14, 2024
gerardsn
deleted the
iss-2909/fail-if-deprecated-network-params-are-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2909