Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider TLS options for network #2864

Closed
reinkrul opened this issue Mar 6, 2024 · 1 comment · Fixed by #2877
Closed

Reconsider TLS options for network #2864

reinkrul opened this issue Mar 6, 2024 · 1 comment · Fixed by #2877
Assignees
Labels
Milestone

Comments

@reinkrul
Copy link
Member

reinkrul commented Mar 6, 2024

We now have network.enabletls for disabling TLS on the gRPC network layer, which can only be set when strict mode is disabled. The option is used for local/workshop settings in which TLS is inconvenient.

To make the minimal setup easier for networkless deployments (did:web only), you don't want to configure anything network. related. So:

  • Remove network.enabletls configuration flag
  • If TLS properties are configured, enable TLS.
  • If no TLS properties are configured, disable TLS.
  • Require TLS to be configured in strict mode (TLS offloading still works; needs to be explicitly configured)

If we decide to keep the network.enabletls option, we should remove the following log warning:

TLS is disabled, which is only meant for demo/workshop purposes!
@reinkrul reinkrul added this to the V6 milestone Mar 6, 2024
@woutslakhorst
Copy link
Member

As far as I can see, enabling/disabling based on existence of TLS configuration is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants