Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: add SocketAddress.parse #56076

Closed
wants to merge 1 commit into from
Closed

net: add SocketAddress.parse #56076

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 29, 2024

Adds a new net.SocketAddress.parse(...) API.

const addr = SocketAddress.parse('123.123.123.123:1234');
console.log(addr.address);  // 123.123.123.123
console.log(addr.port); 1234

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@jasnell jasnell requested review from anonrig and tniessen November 29, 2024 16:01
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Nov 29, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@lpinca lpinca added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 29, 2024
mcollina
mcollina approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell jasnell force-pushed the add-socketaddress-parse branch from 9d8d0c3 to 6d8b1ac Compare November 29, 2024 17:00
@jasnell
net: add SocketAddress.parse
c79ac3b 
Adds a new `net.SocketAddress.parse(...)` API.

```js
const addr = SocketAddress.parse('123.123.123.123:1234');
console.log(addr.address);  // 123.123.123.123
console.log(addr.port); 1234
```
@jasnell jasnell force-pushed the add-socketaddress-parse branch from 6d8b1ac to c79ac3b Compare November 29, 2024 17:22
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 29, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (4efb7ae) to head (c79ac3b).
Report is 32 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56076      +/-   ##
==========================================
+ Coverage   87.99%   88.01%   +0.01%     
==========================================
  Files         656      656              
  Lines      188988   189020      +32     
  Branches    35988    35993       +5     
==========================================
+ Hits       166302   166364      +62     
+ Misses      15848    15829      -19     
+ Partials     6838     6827      -11
Files with missing lines Coverage Δ
lib/internal/socketaddress.js 98.98% <100.00%> (+0.19%) ⬆️

... and 23 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/63851/ 💚

jasnell added a commit that referenced this pull request Dec 4, 2024
@jasnell
net: add SocketAddress.parse
3c2da4b 
Adds a new `net.SocketAddress.parse(...)` API.

```js
const addr = SocketAddress.parse('123.123.123.123:1234');
console.log(addr.address);  // 123.123.123.123
console.log(addr.port); 1234
```

PR-URL: #56076
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Dec 4, 2024

Landed in 3c2da4b

@jasnell jasnell closed this Dec 4, 2024
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@jasnell @nodejs-github-bot
net: add SocketAddress.parse
dd34c2c 
Adds a new `net.SocketAddress.parse(...)` API.

```js
const addr = SocketAddress.parse('123.123.123.123:1234');
console.log(addr.address);  // 123.123.123.123
console.log(addr.port); 1234
```

PR-URL: nodejs#56076
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Dec 6, 2024
@jasnell @targos
net: add SocketAddress.parse
9fba5e1 
Adds a new `net.SocketAddress.parse(...)` API.

```js
const addr = SocketAddress.parse('123.123.123.123:1234');
console.log(addr.address);  // 123.123.123.123
console.log(addr.port); 1234
```

PR-URL: #56076
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos added a commit that referenced this pull request Dec 6, 2024
@targos
2024-12-10, Version 23.4.0 (Current)
ea235ca 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
net:
  * (SEMVER-MINOR) add BlockList.isBlockList(value) (James M Snell) #56078
  * (SEMVER-MINOR) support blockList in net.connect (theanarkh) #56075
  * (SEMVER-MINOR) support blockList in net.Server (theanarkh) #56079
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
@targos targos mentioned this pull request Dec 6, 2024
Merged
aduh95 added a commit that referenced this pull request Dec 10, 2024
@aduh95
2024-12-10, Version 23.4.0 (Current)
e8cf3a6 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
net:
  * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076
  * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
aduh95 added a commit that referenced this pull request Dec 10, 2024
@aduh95
2024-12-10, Version 23.4.0 (Current)
b932930 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
net:
  * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076
  * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@jasnell @aduh95
net: add SocketAddress.parse
a610b5d 
Adds a new `net.SocketAddress.parse(...)` API.

```js
const addr = SocketAddress.parse('123.123.123.123:1234');
console.log(addr.address);  // 123.123.123.123
console.log(addr.port); 1234
```

PR-URL: #56076
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@jasnell @aduh95
net: add SocketAddress.parse
49781bc 
Adds a new `net.SocketAddress.parse(...)` API.

```js
const addr = SocketAddress.parse('123.123.123.123:1234');
console.log(addr.address);  // 123.123.123.123
console.log(addr.port); 1234
```

PR-URL: #56076
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@jasnell @aduh95
net: add SocketAddress.parse
b93a1ce 
Adds a new `net.SocketAddress.parse(...)` API.

```js
const addr = SocketAddress.parse('123.123.123.123:1234');
console.log(addr.address);  // 123.123.123.123
console.log(addr.port); 1234
```

PR-URL: #56076
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 18, 2024
@jasnell @aduh95
net: add SocketAddress.parse
a0a5fe8 
Adds a new `net.SocketAddress.parse(...)` API.

```js
const addr = SocketAddress.parse('123.123.123.123:1234');
console.log(addr.address);  // 123.123.123.123
console.log(addr.port); 1234
```

PR-URL: #56076
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@mcollina mcollina mcollina approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. net Issues and PRs related to the net subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @nodejs-github-bot @mcollina @anonrig @lpinca