Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: add net.BlockList.isBlockList(value) #56078

Closed
wants to merge 1 commit into from
Closed

net: add net.BlockList.isBlockList(value) #56078

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 29, 2024

No description provided.

@jasnell jasnell requested review from anonrig and tniessen November 29, 2024 16:25
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 29, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell requested a review from theanarkh November 29, 2024 16:27
anonrig
anonrig approved these changes Nov 29, 2024
View reviewed changes
lib/internal/blocklist.js Show resolved Hide resolved
@anonrig anonrig added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 29, 2024
lpinca
lpinca approved these changes Nov 29, 2024
View reviewed changes
doc/api/net.md Outdated Show resolved Hide resolved
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 29, 2024
@codecov Codecov

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

atlowChemi
atlowChemi reviewed Dec 2, 2024
View reviewed changes
lib/internal/blocklist.js
/**
* Returns true if the value is a BlockList
* @param {any} value
* @returns {boolean}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use asserts here

Suggested change
* @returns {boolean}
* @returns {asserts value is BlockList}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure what this would accomplish. The method does not assert at all, it just returns true or false and should not throw any errors.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63872/

jasnell added a commit that referenced this pull request Dec 4, 2024
@jasnell
net: add net.BlockList.isBlockList(value)
c7de0ec 
PR-URL: #56078
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Dec 4, 2024

Landed in c7de0ec

@jasnell jasnell closed this Dec 4, 2024
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@jasnell @nodejs-github-bot
net: add net.BlockList.isBlockList(value)
251e63a 
PR-URL: nodejs#56078
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@jasnell @nodejs-github-bot
net: add net.BlockList.isBlockList(value)
590ce68 
PR-URL: nodejs#56078
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit that referenced this pull request Dec 6, 2024
@jasnell @targos
net: add net.BlockList.isBlockList(value)
565b04a 
PR-URL: #56078
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
targos added a commit that referenced this pull request Dec 6, 2024
@targos
2024-12-10, Version 23.4.0 (Current)
ea235ca 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
net:
  * (SEMVER-MINOR) add BlockList.isBlockList(value) (James M Snell) #56078
  * (SEMVER-MINOR) support blockList in net.connect (theanarkh) #56075
  * (SEMVER-MINOR) support blockList in net.Server (theanarkh) #56079
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
@targos targos mentioned this pull request Dec 6, 2024
Merged
aduh95 added a commit that referenced this pull request Dec 10, 2024
@aduh95
2024-12-10, Version 23.4.0 (Current)
e8cf3a6 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
net:
  * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076
  * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
aduh95 added a commit that referenced this pull request Dec 10, 2024
@aduh95
2024-12-10, Version 23.4.0 (Current)
b932930 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
net:
  * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076
  * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@jasnell @aduh95
net: add net.BlockList.isBlockList(value)
1d00522 
PR-URL: #56078
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@jasnell @aduh95
net: add net.BlockList.isBlockList(value)
4f27adf 
PR-URL: #56078
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@jasnell @aduh95
net: add net.BlockList.isBlockList(value)
1b2e013 
PR-URL: #56078
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 18, 2024
@jasnell @aduh95
net: add net.BlockList.isBlockList(value)
92a6c56 
PR-URL: #56078
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@theanarkh theanarkh theanarkh approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasnell @nodejs-github-bot @mcollina @lpinca @anonrig @theanarkh @atlowChemi