process: deprecate `features.{ipv6,uv}` and `features.tls_*` #55545

Renegade334 · 2024-10-26T00:41:37Z

Resolves: #55537

As per the linked issue.

ipv6 and uv are unconditionally true, and have been since v0.5.x.
Not all builds supported ALPN/OCSP/SNI prior to OpenSSL 1.0.2, hence the existence of individual tls_* properties. Since v11.0.0, this is no longer the case, and so these properties are now redundant.

doc/api/deprecations.md

github-actions · 2024-10-26T02:06:10Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @RedYetiDev.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

gireeshpunathil · 2024-10-27T14:19:29Z

doc/api/process.md

 * {boolean}

 A boolean value that is `true` if the current Node.js build includes support for SNI in TLS.

+Since OpenSSL now unconditionally supports SNI, this value is identical to that of


the word now is ephemeral and may not be good at API doc, can you pls use something like `since vx.y or similar?

jasnell

LGTM with the suggested edit.

nodejs-github-bot · 2024-11-23T15:02:47Z

Commit Queue failed

- Loading data for nodejs/node/pull/55545
✔  Done loading data for nodejs/node/pull/55545
----------------------------------- PR info ------------------------------------
Title      process: deprecate `features.{ipv6,uv}` and `features.tls_*` (#55545)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Renegade334:process-features-deprecations -> nodejs:main
Labels     doc, semver-minor, process, notable-change, deprecations
Commits    1
 - process: deprecate `features.{ipv6,uv}` and `features.tls_*`
Committers 1
 - Renegade334 <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/55545
Fixes: https://github.com/nodejs/node/issues/55537
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55545
Fixes: https://github.com/nodejs/node/issues/55537
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - process: deprecate `features.{ipv6,uv}` and `features.tls_*`
   ℹ  This PR was created on Sat, 26 Oct 2024 00:41:37 GMT
   ✔  Approvals: 2
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/55545#pullrequestreview-2397228627
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55545#pullrequestreview-2416975224
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11988131607

Renegade334 · 2024-11-23T15:25:22Z

Ah, node-core-utils, we meet again.

Should now be happy.

nodejs-github-bot · 2024-11-27T04:19:18Z

Landed in ae8280c

panva · 2024-11-27T12:33:33Z

DEP0187 was already taken by the time this PR landed. I wonder if we should make a rule that deprecations Issues and PRs related to deprecations. labeled PRs must be rebased?

Fix in #56018

PR-URL: #55545 Fixes: #55537 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: TODO

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119

PR-URL: nodejs#55545 Fixes: nodejs#55537 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc: * add LJHarb to collaborators (Jordan Harband) #56132 net: * (SEMVER-MINOR) add BlockList.isBlockList(value) (James M Snell) #56078 * (SEMVER-MINOR) support blockList in net.connect (theanarkh) #56075 * (SEMVER-MINOR) support blockList in net.Server (theanarkh) #56079 * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) nodejs#55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) nodejs#56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) nodejs#55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213 PR-URL: #31

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc: * add LJHarb to collaborators (Jordan Harband) #56132 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075 * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076 * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078 * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) nodejs#55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) nodejs#56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) nodejs#55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213 PR-URL: #32

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) nodejs#55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) nodejs#56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) nodejs#55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213 PR-URL: #33

PR-URL: #55545 Fixes: #55537 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 26, 2024

RedYetiDev reviewed Oct 26, 2024

View reviewed changes

doc/api/deprecations.md Outdated Show resolved Hide resolved

doc/api/deprecations.md Outdated Show resolved Hide resolved

doc/api/deprecations.md Outdated Show resolved Hide resolved

Renegade334 force-pushed the process-features-deprecations branch from 5d4b6ac to cab3955 Compare October 26, 2024 05:37

marco-ippolito approved these changes Oct 26, 2024

View reviewed changes

gireeshpunathil reviewed Oct 27, 2024

View reviewed changes

jasnell approved these changes Nov 5, 2024

View reviewed changes

process: deprecate features.{ipv6,uv} and features.tls_*

83a3673

Renegade334 force-pushed the process-features-deprecations branch from cab3955 to 83a3673 Compare November 6, 2024 16:29

jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 23, 2024

juanarbol approved these changes Nov 27, 2024

View reviewed changes

juanarbol added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 27, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024

nodejs-github-bot merged commit ae8280c into nodejs:main Nov 27, 2024
25 checks passed

panva mentioned this pull request Nov 27, 2024

doc: fix deprecation codes #56018

Merged

Renegade334 deleted the process-features-deprecations branch November 30, 2024 16:12

nodejs-github-bot mentioned this pull request Dec 3, 2024

2024-12-10, Version 23.4.0 (Current), @targos #56119

Merged

github-actions bot mentioned this pull request Dec 6, 2024

2024-12-11, Version 23.4.0 (Current), @aduh95 aduh95/node#31

Closed

github-actions bot mentioned this pull request Dec 11, 2024

2024-12-12, Version 23.4.0 (Current) aduh95/node#32

Closed

github-actions bot mentioned this pull request Dec 11, 2024

2024-12-12, Version 23.4.0 (Current) aduh95/node#33

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

process: deprecate `features.{ipv6,uv}` and `features.tls_*` #55545

process: deprecate `features.{ipv6,uv}` and `features.tls_*` #55545

Renegade334 commented Oct 26, 2024 •

edited

Loading

github-actions bot commented Oct 26, 2024

gireeshpunathil Oct 27, 2024

jasnell left a comment

nodejs-github-bot commented Nov 23, 2024

Renegade334 commented Nov 23, 2024

nodejs-github-bot commented Nov 27, 2024

panva commented Nov 27, 2024 •

edited

Loading

process: deprecate features.{ipv6,uv} and features.tls_* #55545

process: deprecate features.{ipv6,uv} and features.tls_* #55545

Conversation

Renegade334 commented Oct 26, 2024 • edited Loading

github-actions bot commented Oct 26, 2024

gireeshpunathil Oct 27, 2024

Choose a reason for hiding this comment

jasnell left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 23, 2024

Renegade334 commented Nov 23, 2024

nodejs-github-bot commented Nov 27, 2024

panva commented Nov 27, 2024 • edited Loading

process: deprecate `features.{ipv6,uv}` and `features.tls_*` #55545

process: deprecate `features.{ipv6,uv}` and `features.tls_*` #55545

Renegade334 commented Oct 26, 2024 •

edited

Loading

panva commented Nov 27, 2024 •

edited

Loading