Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Deprecate process.features.ipv6 and process.features.uv #55537

Closed
Renegade334 opened this issue Oct 25, 2024 · 4 comments · Fixed by #55545
Closed

Proposal: Deprecate process.features.ipv6 and process.features.uv #55537

Renegade334 opened this issue Oct 25, 2024 · 4 comments · Fixed by #55545
Labels
deprecations Issues and PRs related to deprecations.

Comments

@Renegade334
Copy link
Contributor

process.features.ipv6 and process.features.uv have both been hard-coded to true since pre-v1.0.0. Indeed, by the looks of things, process.features.ipv6 has always been hard-coded to true since process.features was first added.

There has been a longstanding todo comment about improving the features API (cc @joyeecheung) but for now, seems like deprecating these would be fairly uncontroversial.
@RedYetiDev RedYetiDev added the deprecations Issues and PRs related to deprecations. label Oct 25, 2024
@marco-ippolito
Copy link
Member

pr welcome

@Renegade334
Copy link
Contributor Author

Renegade334 commented Oct 25, 2024 •
edited
Loading

Where would you recommend these live in terms of deprecation cycle? They've been redundant for well over a decade, so is there a case for sending them straight to runtime?

The tls_* properties are also redundant since v11.0.0 (a76f029) so could probably also take the opportunity to doc-deprecate these.

@RedYetiDev
Copy link
Member

so is there a case for sending them straight to runtime?

I don't believe so, IIRC everything must go through the cycle.

@Renegade334 Renegade334 mentioned this issue Oct 26, 2024
Merged
@bnoordhuis
Copy link
Member

Doc-deprecating is fine (if kind of pointless IMO) but runtime warnings or removing them is potentially disruptive for no benefit whatsoever.

Having a few superfluous properties doesn't cost anything. Just keep them around forever.

targos pushed a commit that referenced this issue Dec 2, 2024
@Renegade334 @targos
process: deprecate features.{ipv6,uv} and features.tls_*
4cdb032 
PR-URL: #55545
Fixes: #55537
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
github-actions bot pushed a commit to aduh95/node that referenced this issue Dec 4, 2024
@Renegade334 @nodejs-github-bot
process: deprecate features.{ipv6,uv} and features.tls_*
a0af24a 
PR-URL: nodejs#55545
Fixes: nodejs#55537
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this issue Dec 4, 2024
@Renegade334 @nodejs-github-bot
process: deprecate features.{ipv6,uv} and features.tls_*
285f45e 
PR-URL: nodejs#55545
Fixes: nodejs#55537
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this issue Dec 4, 2024
@Renegade334 @nodejs-github-bot
process: deprecate features.{ipv6,uv} and features.tls_*
e85d1e8 
PR-URL: nodejs#55545
Fixes: nodejs#55537
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this issue Dec 13, 2024
@Renegade334 @aduh95
process: deprecate features.{ipv6,uv} and features.tls_*
594d11d 
PR-URL: #55545
Fixes: #55537
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this issue Dec 13, 2024
@Renegade334 @aduh95
process: deprecate features.{ipv6,uv} and features.tls_*
1dcb85f 
PR-URL: #55545
Fixes: #55537
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this issue Dec 13, 2024
@Renegade334 @aduh95
process: deprecate features.{ipv6,uv} and features.tls_*
13079df 
PR-URL: #55545
Fixes: #55537
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this issue Dec 18, 2024
@Renegade334 @aduh95
process: deprecate features.{ipv6,uv} and features.tls_*
ca41743 
PR-URL: #55545
Fixes: #55537
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

process: deprecate features.{ipv6,uv} and features.tls_* Renegade334/node
4 participants
@bnoordhuis @Renegade334 @marco-ippolito @RedYetiDev