Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,lib,src,test: unflag sqlite module #55890

Merged
merged 1 commit into from
Nov 19, 2024
Merged

doc,lib,src,test: unflag sqlite module #55890

merged 1 commit into from
Nov 19, 2024
+23 −25

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 17, 2024

As requested in #55854...

This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental.

Fixes: #55854

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Nov 17, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (746b17e) to head (a54b0ac).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55890      +/-   ##
==========================================
- Coverage   88.41%   88.41%   -0.01%     
==========================================
  Files         654      654              
  Lines      188036   188036              
  Branches    36187    36182       -5     
==========================================
- Hits       166260   166257       -3     
- Misses      14989    14990       +1     
- Partials     6787     6789       +2
Files with missing lines Coverage Δ
lib/internal/process/pre_execution.js 90.56% <100.00%> (+0.14%) ⬆️
src/node_options.cc 87.46% <ø> (ø)
src/node_options.h 98.27% <100.00%> (ø)

... and 38 files with indirect coverage changes

---- 🚨 Try these New Features:

@RedYetiDev RedYetiDev added the sqlite Issues and PRs related to the SQLite subsystem. label Nov 17, 2024
@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 17, 2024 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/63605/ 🟡

@cjihrig cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Nov 18, 2024
@cjihrig
doc,lib,src,test: unflag sqlite module
a54b0ac 
This commit allows the node:sqlite module to be used without
starting Node with a CLI flag. The module is still experimental.

Fixes: nodejs#55854
@cjihrig
Copy link
Contributor Author

cjihrig commented Nov 18, 2024

Rebased to fix a minor conflict in the docs from #54181.

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63618/

@mcollina mcollina added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 18, 2024
mcollina
mcollina approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco-ippolito marco-ippolito added the notable-change PRs with changes that should be highlighted in changelogs. label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @marco-ippolito.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63623/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63625/

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 1d01ad6 into nodejs:main Nov 19, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1d01ad6

This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Nov 28, 2024
@aduh95
2024-12-01, Version 23.4.0 (Current)
e260d8f 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213

PR-URL: #25
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Nov 28, 2024
@aduh95
2024-12-01, Version 23.4.0 (Current)
d75d669 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213

PR-URL: #26
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Nov 28, 2024
@aduh95
2024-12-01, Version 23.4.0 (Current)
b5a412c 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213

PR-URL: #27
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Nov 28, 2024
@aduh95
2024-12-01, Version 23.4.0 (Current)
2a8b3d3 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213

PR-URL: #28
@github-actions github-actions bot mentioned this pull request Nov 30, 2024
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Nov 30, 2024
@aduh95
2024-12-01, Version 23.4.0 (Current)
0d51695 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213

PR-URL:
@github-actions github-actions bot mentioned this pull request Nov 30, 2024
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Nov 30, 2024
@aduh95
2024-12-01, Version 23.4.0 (Current)
e7c60bf 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213

PR-URL: #30
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
@nodejs-github-bot
2024-12-04, Version 23.4.0 (Current)
858a6b3 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
net:
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: TODO
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
@nodejs-github-bot
2024-12-04, Version 23.4.0 (Current)
ec5c0be 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
net:
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
targos pushed a commit that referenced this pull request Dec 3, 2024
@nodejs-github-bot @targos
2024-12-04, Version 23.4.0 (Current)
93bc158 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
net:
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
targos added a commit that referenced this pull request Dec 5, 2024
@targos
2024-12-05, Version 23.4.0 (Current)
747338a 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
net:
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
targos added a commit that referenced this pull request Dec 6, 2024
@targos
2024-12-10, Version 23.4.0 (Current)
ea235ca 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
net:
  * (SEMVER-MINOR) add BlockList.isBlockList(value) (James M Snell) #56078
  * (SEMVER-MINOR) support blockList in net.connect (theanarkh) #56075
  * (SEMVER-MINOR) support blockList in net.Server (theanarkh) #56079
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Dec 6, 2024
@aduh95
2024-12-11, Version 23.4.0 (Current)
d17bde6 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) nodejs#55604
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890
net:
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) nodejs#56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) nodejs#55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213

PR-URL: #31
aduh95 added a commit that referenced this pull request Dec 10, 2024
@aduh95
2024-12-10, Version 23.4.0 (Current)
e8cf3a6 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
net:
  * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076
  * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
aduh95 added a commit that referenced this pull request Dec 10, 2024
@aduh95
2024-12-10, Version 23.4.0 (Current)
b932930 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
net:
  * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076
  * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@cjihrig @aduh95
doc,lib,src,test: unflag sqlite module
695f582 
This commit allows the node:sqlite module to be used without
starting Node with a CLI flag. The module is still experimental.

Fixes: #55854
PR-URL: #55890
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Dec 11, 2024
@aduh95
2024-12-12, Version 23.4.0 (Current)
3e89274 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) nodejs#55604
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890
net:
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) nodejs#56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) nodejs#55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213

PR-URL: #32
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Dec 11, 2024
@aduh95
2024-12-12, Version 23.4.0 (Current)
82c7d0b 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) nodejs#55604
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890
net:
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) nodejs#56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) nodejs#55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213

PR-URL: #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecastelli jakecastelli jakecastelli approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@MoLow MoLow MoLow approved these changes

@targos targos targos approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. notable-change PRs with changes that should be highlighted in changelogs. process Issues and PRs related to the process subsystem. semver-minor PRs that contain new features and should be released in the next minor version. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unflag node:sqlite
8 participants
@cjihrig @nodejs-github-bot @mcollina @targos @MoLow @marco-ippolito @jakecastelli @RedYetiDev