v21.1.0 release proposal #50335
Merged
v21.1.0 release proposal #50335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use f-strings for formatting. - Use raw strings for regexes alongside f-strings. - Use a generator. - Remove unnecessary `else` clause. PR-URL: #50011 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Christian Clauss <[email protected]>
Original commit message:
[api] add line breaks to the output of Message::PrintCurrentStackTrace
Previously this prints the stack trace without line breaks and it
can be difficult to read. This also affects
--abort-on-uncaught-exception. This patch adds line breaks to the
output to improve readability.
Change-Id: I4c44b529f8c829329f784b0859b1d13c9ec56838
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4925009
Reviewed-by: Leszek Swirski <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#90360}
Refs: v8/v8@2590224
PR-URL: #50156
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
PR-URL: #50173 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #50175 Fixes: #50159 Refs: #50165 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
The test never actually tested what it claims to test because it did not properly insert separators before `..`. PR-URL: #50124 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
- update security release process to reflect current way to ask for tweet to amplify security release blog posts. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #50166 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #50172 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #50187 Fixes: #50176 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #50102 Reviewed-By: Richard Lau <[email protected]>
PR-URL: #50179 Refs: nodejs-private/node-private#485 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #50110 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Set a default host-defined option for vm.compileFunction so that it's consistent with vm.Script. PR-URL: #50137 Refs: #35375 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Instead of using the public versions of the vm APIs internally, use the internal versions so that we can skip unnecessary argument validation. The public versions would need special care to the generation of host-defined options to hit the isolate compilation cache when imporModuleDynamically isn't used, while internally it's almost always used, so this allows us to handle the host-defined options separately. PR-URL: #50137 Refs: #35375 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Users cannot access any API that can be used to return a module or module namespace in this callback without --experimental-vm-modules anyway, so this would eventually lead to a rejection. This patch rejects in this case with our own error message and use a constant host-defined option for the rejection, so that scripts with the same source can still be compiled using the compilation cache if no `import()` is actually called in the script. PR-URL: #50137 Refs: #35375 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Refs: v8/v8@11.8.172.13...11.8.172.15 PR-URL: #50114 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #49963 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Raz Luvaton <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #50103 PR-URL: #50217 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
PR-URL: #50218 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #50211 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
This commit adds documentation and tests for the 'flush' option of the fs.appendFile family of functions. Technically, support was indirectly added in #50009, but this makes it more official. Refs: #49886 Refs: #50009 PR-URL: #50095 Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #50223 Refs: #49630 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #50181 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]>
PR-URL: #50127 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #50221 Refs: #49985 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
The test is only flaky on x86 Windows. Fixes: #50220 PR-URL: #50238 Refs: #49962 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #49962 Refs: nodejs/performance#106 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
PR-URL: #49962 Refs: nodejs/performance#106 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
PR-URL: #49962 Refs: nodejs/performance#106 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
PR-URL: #49962 Refs: nodejs/performance#106 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
PR-URL: #49962 Refs: nodejs/performance#106 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
|
@joyeecheung if it should be a notable change, it should have the |
targos
force-pushed
the
v21.1.0-proposal
branch
from
bbaa869
to
0cba6f1
Compare
targos
added a commit
that referenced
this pull request
Oct 24, 2023
Notable changes: doc: * add H4ad to collaborators (Vinícius Lourenço) #50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) #50095 lib: * (SEMVER-MINOR) add `navigator.userAgent` (Yagiz Nizipli) #50200 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) #50187 * call helper function from push and unshift (Raz Luvaton) #50173 PR-URL: #50335
|
Draft text: |
Ah okay, I can update the changelog afterwards |
github-actions
bot
removed
the
request-ci
Notable changes: doc: * add H4ad to collaborators (Vinícius Lourenço) #50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) #50095 lib: * (SEMVER-MINOR) add `navigator.userAgent` (Yagiz Nizipli) #50200 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) #50187 * call helper function from push and unshift (Raz Luvaton) #50173 PR-URL: #50335
targos
force-pushed
the
v21.1.0-proposal
branch
from
0cba6f1
to
f4e5beb
Compare
RafaelGSS
approved these changes
Oct 24, 2023
richardlau
approved these changes
Oct 24, 2023
targos
added a commit
that referenced
this pull request
Oct 24, 2023
Notable changes: doc: * add H4ad to collaborators (Vinícius Lourenço) #50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) #50095 lib: * (SEMVER-MINOR) add `navigator.userAgent` (Yagiz Nizipli) #50200 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) #50187 * call helper function from push and unshift (Raz Luvaton) #50173 PR-URL: #50335
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 24, 2023
richardlau
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 24, 2023
github-merge-queue bot
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 24, 2023
joyeecheung
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 24, 2023
Refs: nodejs/node#50335 (comment) Signed-off-by: Joyee Cheung <[email protected]>
5 tasks
16 tasks
github-merge-queue bot
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 25, 2023
update notable changes in v21.1.0 Refs: nodejs/node#50335 (comment) Signed-off-by: Joyee Cheung <[email protected]>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Notable changes: doc: * add H4ad to collaborators (Vinícius Lourenço) nodejs#50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) nodejs#50096 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) nodejs#50095 lib: * (SEMVER-MINOR) add `navigator.userAgent` (Yagiz Nizipli) nodejs#50200 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) nodejs#50187 * call helper function from push and unshift (Raz Luvaton) nodejs#50173 PR-URL: nodejs#50335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-10-24, Version 21.1.0 (Current), @targos
Notable Changes
Automatically detect and run ESM syntax
The new flag
--experimental-detect-modulecan be used to automatically runES modules when their syntax can be detected. For “ambiguous” files, which are
.jsor extensionless files with nopackage.jsonwith atypefield, Node.jswill parse the file to detect ES module syntax; if found, it will run the file
as an ES module, otherwise it will run the file as a CommonJS module.
The same applies to string input via
--evalorSTDIN.We hope to make detection enabled by default in a future version of Node.js.
Detection increases startup time, so we encourage everyone — especially package
authors — to add a
typefield topackage.json, even for the default"type": "commonjs". The presence of atypefield, or explicit extensionssuch as
.mjsor.cjs, will opt out of detection.Contributed by Geoffrey Booth in #50096.
vm: fix V8 compilation cache support for vm.Script
Previously repeated compilation of the same source code using
vm.Scriptstopped hitting the V8 compilation cache after v16.x when support forimportModuleDynamicallywas added tovm.Script, resulting in a performance regression that blocked users (in particular Jest users) from upgrading from v16.x.The recent fixes landed in v21.1.0 allow the compilation cache to be hit again for
vm.Scriptwhen--experimental-vm-modulesis not used even in the presence of theimportModuleDynamicallyoption, so that users affected by the performance regression can now upgrade. Ongoing work is also being done to enable compilation cache support forvm.CompileFunction.Contributed by Joyee Cheung in #50137
Other Notable Changes
3729e33358] - doc: add H4ad to collaborators (Vinícius Lourenço) #5021718862e4d5d] - (SEMVER-MINOR) fs: addflushoption toappendFile()functions (Colin Ihrig) #500955a52c518ef] - (SEMVER-MINOR) lib: addnavigator.userAgent(Yagiz Nizipli) #50200789372a072] - (SEMVER-MINOR) stream: allow pass stream class tostream.compose(Alex Yang) #50187f3a9ea0bc4] - stream: improve performance of readable stream reads (Raz Luvaton) #50173dda33c2bf1] - vm: reject in importModuleDynamically without --experimental-vm-modules (Joyee Cheung) #501373999362c59] - vm: use internal versions of compileFunction and Script (Joyee Cheung) #50137a54179f0e0] - vm: unify host-defined option generation in vm.compileFunction (Joyee Cheung) #50137Commits
9cd68b9083] - buffer: remove unnecessary assignment in fromString (Tobias Nießen) #50199a362c276ec] - crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey (Filip Skokan) #50234f4da308f8d] - deps: V8: cherry-pick f7d000a7ae7b (Luke Albao) #50302269e268c38] - deps: update ada to 2.7.2 (Node.js GitHub Bot) #5033803a31ce41e] - deps: update corepack to 0.22.0 (Node.js GitHub Bot) #50325000531781b] - deps: update undici to 5.26.4 (Node.js GitHub Bot) #50274f050668c14] - deps: update c-ares to 1.20.1 (Node.js GitHub Bot) #50082ba258b682b] - deps: update c-ares to 1.20.0 (Node.js GitHub Bot) #50082571f7ef1fa] - deps: patch V8 to 11.8.172.15 (Michaël Zasso) #50114943047e800] - deps: V8: cherry-pick 25902244ad1a (Joyee Cheung) #50156db2a1cf1cb] - doc: fixnavigator.hardwareConcurrencyexample (Tobias Nießen) #502786e537aeb44] - doc: explain how to disable navigator (Geoffrey Booth) #50310c40de82d62] - doc: add loong64 info into platform list (Shi Pujin) #500861c21a1880b] - doc: update release process LTS step (Richard Lau) #502992473aa3672] - doc: fix release process table of contents (Richard Lau) #50216ce9d84eae3] - doc: update apistream.compose(Alex Yang) #50206dacee4d9b5] - doc: add ReflectConstruct to known perf issues (Vinicius Lourenço) #5011182363be2ac] - doc: fix typo in dgram docs (Peter Johnson) #502118c1a46c751] - doc: fix H4ad collaborator sort (Vinicius Lourenço) #502183729e33358] - doc: add H4ad to collaborators (Vinícius Lourenço) #50217bac872cbd0] - doc: update release-stewards with last sec-release (Rafael Gonzaga) #5017906b7724f14] - doc: add command to keep major branch sync (Rafael Gonzaga) #5010247633ab086] - doc: add loong64 to list of architectures (Shi Pujin) #501721f40ca1b91] - doc: update security release process (Michael Dawson) #50166998feda118] - esm: do not give wrong hints when detecting file format (Antoine du Hamel) #50314e375063e01] - (SEMVER-MINOR) esm: detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096c76eb27971] - esm: improve check for ESM syntax (Geoffrey Booth) #501277740bf820c] - esm: rename error code related to import attributes (Antoine du Hamel) #501810cc176ef25] - fs: improve error performance forreadSync(Jungku Lee) #500335942edb774] - fs: improve error performance forfsyncSync(Jungku Lee) #498806ec5abadc0] - fs: improve error performance formkdirSync(CanadaHonk) #49847c5ff000cb1] - fs: improve error performance ofrealpathSync(Yagiz Nizipli) #499626eeaa02f5c] - fs: improve error performance oflchownSync(Yagiz Nizipli) #49962dc9ac8d41c] - fs: improve error performance ofsymlinkSync(Yagiz Nizipli) #49962bc6f279261] - fs: improve error performance ofreadlinkSync(Yagiz Nizipli) #49962275987841e] - fs: improve error performance ofmkdtempSync(Yagiz Nizipli) #4996281f15274e2] - fs: improve error performance oflinkSync(Yagiz Nizipli) #49962f766c04856] - fs: improve error performance ofchownSync(Yagiz Nizipli) #49962610036c67d] - fs: improve error performance ofrenameSync(Yagiz Nizipli) #4996218862e4d5d] - (SEMVER-MINOR) fs: add flush option to appendFile() functions (Colin Ihrig) #500953f8cbb15cb] - http2: allow streams to complete gracefully after goaway (Michael Lumish) #502021464eba1a0] - lib: improve performance of validateStringArray and validateBooleanArray (Aras Abbasi) #497565a52c518ef] - (SEMVER-MINOR) lib: addnavigator.userAgent(Yagiz Nizipli) #50200b6021ab8f6] - lib: reduce overhead of blob clone (Vinicius Lourenço) #50110be19d9baa1] - meta: move Trott to TSC regular member (Rich Trott) #5029791e373f8e9] - node-api: return napi_exception_pending on proxy handlers (Chengzhong Wu) #48607531a3ae4b5] - stream: simplify prefinish (Robert Nagy) #50204514ac86579] - stream: reduce scope of readable bitmap details (Robert Nagy) #49963789372a072] - (SEMVER-MINOR) stream: allow pass stream class tostream.compose(Alex Yang) #50187f3a9ea0bc4] - stream: call helper function from push and unshift (Raz Luvaton) #50173a9ca7b32e7] - test: improve watch mode test (Moshe Atlow) #5031963b7059efd] - test: settest-watch-mode-inspectas flaky (Yagiz Nizipli) #502597f87084b05] - Revert "test: settest-esm-loader-resolve-typeas flaky" (Antoine du Hamel) #503154d390e2de4] - test: replace forEach with for..of in test-http-perf_hooks.js (Niya Shiyas) #4981867c599ec39] - test: replace forEach with for..of in test-net-isipv4.js (Niya Shiyas) #4982219d3ce2494] - test: deflaketest-esm-loader-resolve-type(Antoine du Hamel) #502732d8d6c5701] - test: replace forEach with for..of in test-http2-server (Niya Shiyas) #49819af31d51e5a] - test: replace forEach with for..of in test-http2-client-destroy.js (Niya Shiyas) #49820465ad2a5ce] - test: updateurlweb platform tests (Yagiz Nizipli) #502643b80a6894c] - test: settest-emit-after-on-destroyedas flaky (Yagiz Nizipli) #5024657adbdd156] - test: set inspector async stack test as flaky (Yagiz Nizipli) #502446507f66404] - test: set test-worker-nearheaplimit-deadlock flaky (StefanStojanovic) #5027721a6ba548d] - test: settest-cli-node-optionsas flaky (Yagiz Nizipli) #50296c55f8f30cb] - test: reduce the number of requests and parsers (Luigi Pinca) #502405129bedfa2] - test: set crypto-timing test as flaky (Yagiz Nizipli) #502329bc5ab5e07] - test: settest-structuredclone-*as flaky (Yagiz Nizipli) #50261317e447ddc] - test: deflaketest-loaders-workers-spawned(Antoine du Hamel) #502510c710daae2] - test: improve code coverage of diagnostics_channel (Jithil P Ponnan) #500537c6e4d7ec3] - test: settest-esm-loader-resolve-typeas flaky (Yagiz Nizipli) #50226c8744909b0] - test: set inspector async hook test as flaky (Yagiz Nizipli) #502523e38001739] - test: skip test-benchmark-os.js on IBM i (Abdirahim Musse) #50208dd66fdfb7b] - test: set parallel http server test as flaky (Yagiz Nizipli) #50227a38d1311bf] - test: set test-worker-nearheaplimit-deadlock flaky (Stefan Stojanovic) #502388efb75fd80] - test: settest-runner-watch-modeas flaky (Yagiz Nizipli) #50221143ddded74] - test: set sea snapshot tests as flaky (Yagiz Nizipli) #50223ae905a8f35] - test: fix defect path traversal tests (Tobias Nießen) #50124ce27ee701b] - tls: reduce TLS 'close' event listener warnings (Tim Perry) #50136ab4bae8e1f] - tools: drop support for osx notarization with gon (Ulises Gascón) #502915df3d5abcc] - tools: update comment inupdate-uncidi.shandacorn_version.h(Jungku Lee) #50175bf7b94f0b3] - tools: refactor checkimports.py (Mohammed Keyvanzadeh) #500115dc454a837] - util: remove internal mime fns from benchmarks (Aras Abbasi) #502018f7eb15603] - vm: use import attributes instead of import assertions (Antoine du Hamel) #50141dda33c2bf1] - vm: reject in importModuleDynamically without --experimental-vm-modules (Joyee Cheung) #501373999362c59] - vm: use internal versions of compileFunction and Script (Joyee Cheung) #50137a54179f0e0] - vm: unify host-defined option generation in vm.compileFunction (Joyee Cheung) #5013787be790fa9] - worker: handle detachedMessagePortfrom a different context (Juan José) #49150