Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach with for..of in test-http2-client-destroy.js #49820

Merged
merged 3 commits into from
Oct 21, 2023
Merged

test: replace forEach with for..of in test-http2-client-destroy.js #49820

merged 3 commits into from
Oct 21, 2023

Conversation

niyashiyas
Copy link
Contributor

Replaced forEach with for..of in test-http2-client-destroy.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 23, 2023
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 23, 2023
@tniessen
Copy link
Member

Please update all your PRs to comply with our commit message guidelines. In particular, there should be a lowercase imperative verb after the test: prefix (e.g., test: replace ... instead of test: Replaced ...). You can find instructions for updating an existing PR here.

@niyashiyas niyashiyas changed the title test: Replaced forEach with for..of in test-http2-client-destroy.js test: replace forEach with for..of in test-http2-client-destroy.js Sep 30, 2023
@niyashiyas
Copy link
Contributor Author

@tniessen, I have redid all the commit messages as per your instructions.
Please review it, when you are free ..
Thanks a ton !

@lpinca lpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 14, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54782/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54970/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit fd562ef into nodejs:main Oct 21, 2023
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fd562ef

targos pushed a commit that referenced this pull request Oct 23, 2023
@niyashiyas @targos
test: replace forEach with for..of in test-http2-client-destroy.js
af31d51 
PR-URL: #49820
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@niyashiyas @alexfernandez
test: replace forEach with for..of in test-http2-client-destroy.js
0152df3 
PR-URL: nodejs#49820
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@niyashiyas @targos
test: replace forEach with for..of in test-http2-client-destroy.js
8c15281 
PR-URL: #49820
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@niyashiyas @targos
test: replace forEach with for..of in test-http2-client-destroy.js
128ca3e 
PR-URL: #49820
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: replace forEach with for..of in
c22d9bb 
PR-URL: nodejs/node#49820
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: replace forEach with for..of in
6ecf529 
PR-URL: nodejs/node#49820
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen left review comments

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niyashiyas @tniessen @nodejs-github-bot @lpinca