test: set test-structuredclone-* as flaky
#50261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
anonrig
added
flaky-test
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
himself65
approved these changes
Oct 18, 2023
StefanStojanovic
approved these changes
Oct 19, 2023
H4ad
approved these changes
Oct 19, 2023
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f9c290f |
This was referenced Oct 20, 2023
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
PR-URL: #50261 Refs: #50260 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50261 Refs: nodejs#50260 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50261 Refs: #50260 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR-URL: #50261 Refs: #50260 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
mertcanaltin
pushed a commit
to mertcanaltin/node
that referenced
this pull request
Dec 19, 2023
PR-URL: nodejs#50261 Refs: nodejs#50260 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> meta: move Trott to TSC regular member At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: nodejs#50297 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Richard Lau <[email protected]> node-api: refactor napi set property function for improved performance fix: lint fix: lint refactor: Improve performance by using internalized property keys refactor: Update node_api_create_property_key_utf16 signature and remove napi_set_property_utf16 lint lint fix: Resolve compilation error in node_api_create_property_key_utf16 fix: Resolve type conversion error in node_api_create_property_key_utf16 refactor: Simplify node_api_create_property_key_utf16 implementation lint add node_api_create_property_key_utf16 property name added doc for node_api_create_property_key_utf16 lint lint update napi doc for node_api_create_property_key_utf16 update: code snipet test: added test for node_api_create_property_key_utf16 lint lint lint call node_api_create_property_key_utf16 Update doc/api/n-api.md Co-authored-by: Chengzhong Wu <[email protected]> Update test/js-native-api/test_string/test_string.c Co-authored-by: Chengzhong Wu <[email protected]> Update test/js-native-api/test_string/test_string.c Co-authored-by: Chengzhong Wu <[email protected]> Update doc/api/n-api.md Co-authored-by: Chengzhong Wu <[email protected]> added TestPropertyKeyUtf16 napi_property_descriptor lint doc lint cpp minor updates to PR nodejs#50282 feat: removed not used function for test Update doc/api/n-api.md Co-authored-by: Michael Dawson <[email protected]> Update doc/api/n-api.md Co-authored-by: Michael Dawson <[email protected]>
mertcanaltin
pushed a commit
to mertcanaltin/node
that referenced
this pull request
Dec 19, 2023
PR-URL: nodejs#50261 Refs: nodejs#50260 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> meta: move Trott to TSC regular member At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: nodejs#50297 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Richard Lau <[email protected]> node-api: refactor napi set property function for improved performance fix: lint fix: lint refactor: Improve performance by using internalized property keys refactor: Update node_api_create_property_key_utf16 signature and remove napi_set_property_utf16 lint lint fix: Resolve compilation error in node_api_create_property_key_utf16 fix: Resolve type conversion error in node_api_create_property_key_utf16 refactor: Simplify node_api_create_property_key_utf16 implementation lint add node_api_create_property_key_utf16 property name added doc for node_api_create_property_key_utf16 lint lint update napi doc for node_api_create_property_key_utf16 update: code snipet test: added test for node_api_create_property_key_utf16 lint lint lint call node_api_create_property_key_utf16 Update doc/api/n-api.md Co-authored-by: Chengzhong Wu <[email protected]> Update test/js-native-api/test_string/test_string.c Co-authored-by: Chengzhong Wu <[email protected]> Update test/js-native-api/test_string/test_string.c Co-authored-by: Chengzhong Wu <[email protected]> Update doc/api/n-api.md Co-authored-by: Chengzhong Wu <[email protected]> added TestPropertyKeyUtf16 napi_property_descriptor lint doc lint cpp minor updates to PR nodejs#50282 feat: removed not used function for test Update doc/api/n-api.md Co-authored-by: Michael Dawson <[email protected]> Update doc/api/n-api.md Co-authored-by: Michael Dawson <[email protected]>
mertcanaltin
pushed a commit
to mertcanaltin/node
that referenced
this pull request
Dec 19, 2023
PR-URL: nodejs#50261 Refs: nodejs#50260 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> meta: move Trott to TSC regular member At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: nodejs#50297 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Richard Lau <[email protected]> node-api: refactor napi set property function for improved performance fix: lint fix: lint refactor: Improve performance by using internalized property keys refactor: Update node_api_create_property_key_utf16 signature and remove napi_set_property_utf16 lint lint fix: Resolve compilation error in node_api_create_property_key_utf16 fix: Resolve type conversion error in node_api_create_property_key_utf16 refactor: Simplify node_api_create_property_key_utf16 implementation lint add node_api_create_property_key_utf16 property name added doc for node_api_create_property_key_utf16 lint lint update napi doc for node_api_create_property_key_utf16 update: code snipet test: added test for node_api_create_property_key_utf16 lint lint lint call node_api_create_property_key_utf16 Update doc/api/n-api.md Co-authored-by: Chengzhong Wu <[email protected]> Update test/js-native-api/test_string/test_string.c Co-authored-by: Chengzhong Wu <[email protected]> Update test/js-native-api/test_string/test_string.c Co-authored-by: Chengzhong Wu <[email protected]> Update doc/api/n-api.md Co-authored-by: Chengzhong Wu <[email protected]> added TestPropertyKeyUtf16 napi_property_descriptor lint doc lint cpp minor updates to PR nodejs#50282 feat: removed not used function for test Update doc/api/n-api.md Co-authored-by: Michael Dawson <[email protected]> Update doc/api/n-api.md Co-authored-by: Michael Dawson <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#50261 Refs: nodejs/node#50260 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#50261 Refs: nodejs/node#50260 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #50260