Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix update-acorn.sh and undici_version.h path #50165

Merged
merged 4 commits into from
Oct 12, 2023
Merged

tools: fix update-acorn.sh and undici_version.h path #50165

merged 4 commits into from
Oct 12, 2023

Conversation

Keksonoid
Copy link
Contributor

Fixes: #50159

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 12, 2023
@marco-ippolito marco-ippolito removed the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 12, 2023
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Oct 12, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

mhdawson
mhdawson approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 merged commit 766198b into nodejs:main Oct 12, 2023
25 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Oct 12, 2023

Landed in 766198b, thanks for the contribution!

@pluris pluris mentioned this pull request Oct 13, 2023
Merged
@RafaelGSS RafaelGSS mentioned this pull request Oct 15, 2023
Merged
aduh95 pushed a commit that referenced this pull request Oct 15, 2023
tools: update comment in update-uncidi.sh and acorn_version.h
f09a50c 
PR-URL: #50175
Fixes: #50159
Refs: #50165
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
kumarrishav pushed a commit to kumarrishav/node that referenced this pull request Oct 16, 2023
@kumarrishav
tools: update comment in update-uncidi.sh and acorn_version.h
8bba0df 
PR-URL: nodejs#50175
Fixes: nodejs#50159
Refs: nodejs#50165
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
targos pushed a commit that referenced this pull request Oct 23, 2023
@targos
tools: update comment in update-uncidi.sh and acorn_version.h
5df3d5a 
PR-URL: #50175
Fixes: #50159
Refs: #50165
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@Keksonoid @alexfernandez
tools: fix comments referencing dep_updaters scripts
b388426 
PR-URL: nodejs#50165
Fixes: nodejs#50159
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@alexfernandez
tools: update comment in update-uncidi.sh and acorn_version.h
72bb5bc 
PR-URL: nodejs#50175
Fixes: nodejs#50159
Refs: nodejs#50165
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@Keksonoid @targos
tools: fix comments referencing dep_updaters scripts
b959d36 
PR-URL: #50165
Fixes: #50159
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@targos
tools: update comment in update-uncidi.sh and acorn_version.h
05ee350 
PR-URL: #50175
Fixes: #50159
Refs: #50165
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito left review comments

@aduh95 aduh95 aduh95 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@lpinca lpinca lpinca approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undici_version.h and acorn_version.h displaying wrong update script path
7 participants
@Keksonoid @nodejs-github-bot @aduh95 @panva @lpinca @mhdawson @marco-ippolito