test: skip test-benchmark-os.js on IBM i #50208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
richardlau
approved these changes
Oct 17, 2023
github-actions
bot
removed
the
request-ci
|
Fast-track has been requested by @mhdawson. Please 👍 to approve. |
|
I have an idea on how to be more specific, but think it's good to land this quickly to get the nightly build back to green. |
|
I didnt know that the uptime is not working on ibm :/ |
Uzlopak
approved these changes
Oct 17, 2023
Yes we will look into how to skip this one individually but for now we will skip the benchmark until we get a patch ready. |
mhdawson
pushed a commit
that referenced
this pull request
Oct 18, 2023
PR-URL: #50208 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in 286fdaf |
This was referenced Oct 19, 2023
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
PR-URL: #50208 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50208 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50208 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change skips the entire test-benchmark-os.js suite on IBM i. Currently this is failing due to os.uptime call:
node/benchmark/os/uptime.js
Line 4 in ea595eb
Instead of skipping the entire os benchmark suite, I would rather skip just the uptime benchmark
but I'm not sure how to achieve this. Anyone have any ideas to skip one of the os benchmarks?
CC
@nodejs/platform-ibmi
@richardlau
Fixes #50207