Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: benchmark/test-benchmark-os fails on IBM i #50207

Closed
abmusse opened this issue Oct 17, 2023 · 1 comment
Closed

test: benchmark/test-benchmark-os fails on IBM i #50207

abmusse opened this issue Oct 17, 2023 · 1 comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. ibm i Issues and PRs related to the IBM i platform.

Comments

@abmusse
Copy link
Contributor

abmusse commented Oct 17, 2023

CI: https://ci.nodejs.org/job/node-test-commit-ibmi/1332/nodes=ibmi73-ppc64/testReport/(root)/benchmark/test_benchmark_os/

test-benchmark-os.js now includes an os.uptime benchmark.

For reference, this commit adds the uptime benchmark: 0f0dd1a

This test fails is due to the fact that os.uptime returns enosys on IBM i.

https://github.com/libuv/libuv/blame/dc1bb0088e8fbb92c81beb55341dcb7b4079717f/src/unix/ibmi.c#L283

Welcome to Node.js v20.5.1.
Type ".help" for more information.
> require('os').uptime()
Uncaught:
SystemError [ERR_SYSTEM_ERROR]: A system error occurred: uv_uptime returned ENOSYS (function not implemented)
    at __node_internal_captureLargerStackTrace (node:internal/errors:496:5)
    at new SystemError (node:internal/errors:256:5)
    at new NodeError (node:internal/errors:367:7)
    at Object.__node_internal_checkError [as uptime] (node:os:68:13) {
  code: 'ERR_SYSTEM_ERROR',
  info: {
    errno: -109,
    code: 'ENOSYS',
    message: 'function not implemented',
    syscall: 'uv_uptime'
  },
  errno: [Getter/Setter: -109],
  syscall: [Getter/Setter: 'uv_uptime']
}

We would need to find a way to skip this uptime benchmark individually (on IBM i) if possible. Otherwise we may need to disable running the test-benchmark-os.js in the meantime (on IBM i).

@richardlau richardlau added benchmark Issues and PRs related to the benchmark subsystem. ibm i Issues and PRs related to the IBM i platform. labels Oct 17, 2023
@mhdawson
Copy link
Member

Closing as it passed in the nightly last night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. ibm i Issues and PRs related to the IBM i platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants