This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Co-authored-by: Cade Daniel <[email protected]>
Co-authored-by: zhangdacheng <[email protected]> Co-authored-by: Woosuk Kwon <[email protected]>
Signed-off-by: Tao He <[email protected]>
Co-authored-by: Daniel Clark <[email protected]>
…roject#3373) Co-authored-by: Cade Daniel <[email protected]>
robertgshaw2-neuralmagic
requested review from
tlrmchlsmth,
andy-neuma,
varun-sundar-rabindranath,
mgoin,
bnellnm,
SageMoore and
LucasWilkinson
March 15, 2024 12:35
SageMoore
approved these changes
Mar 15, 2024
mgoin
reviewed
Mar 15, 2024
.buildkite/test-pipeline.yaml
Outdated
Comment on lines
17
to
22
- label: Core Test | ||
command: pytest -v -s core | ||
|
||
- label: Core Test | ||
command: pytest -v -s core | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks duplicated?
Hey @robertgshaw2-neuralmagic - can you update the PR description with this template 7bbd2cc something like
|
removed duplicated test in buildkite (bad merge)
varun-sundar-rabindranath
approved these changes
Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
54be8a0
NOTES
./format.sh
runs yapf and ruff only on thenm-vllm/vllm
directory whereas our automation runs on everything in thenm-vllm
, so it was a bit tricky for me to catch why the automation was failing. cc @varun-sundar-rabindranath please review the benchmark directory in detailPrimary upstream changes:
Kernels
batched_rotary_embedding
gelu_tanh_and_mul
Core
LLMEngine
refactor <<< adds new layer of abstraction to vLLM. All should look at thisTEST PLAN: