Fix: AttributeError in OpenAI-compatible server
#3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
approved these changes
Feb 28, 2024
Great spotting! The type should really be |
|
Cool, I'll push a quick fix. |
|
@simon-mo Seems like it's all good to go. |
|
@jaywonchung Thanks for the PR! 😄 |
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Mar 4, 2024
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a small typo that triggers an
AttributeErrorin the OpenAI-compatible server whenadd_generation_promptisFalse.Side note, it's unclear to me why
ChatCompletionRequest.messagesis typed asUnion[str, List[Dict[str, str]]]instead of justList[Dict[str, str]]. The OpenAI chat API spec also says it's an array. Ifmessagescan sometimes actually bestr, the modified line will raise an error and will require this case to be handled.I'm not familiar enough with how stuff works in vLLM to confidently modify one of the core schemas, but I can push a quick fix to this PR if you think it's appropriate.