chore(vllm): codespell for spell checking #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mspronesti
force-pushed
the
chore/spell
branch
from
335b122 to
1a55dac
Compare
|
@simon-mo What do you think about this? It looks useful to me. |
|
looks good indeed. Would be great to add this to format.sh as well! |
mspronesti
force-pushed
the
chore/spell
branch
from
2ab86ab to
4151f68
Compare
mspronesti
force-pushed
the
chore/spell
branch
from
4151f68 to
5816391
Compare
|
@simon-mo @WoosukKwon Done. I also fixed some ruff errors being raised because of the |
|
@simon-mo let's merge this? |
simon-mo
approved these changes
Feb 22, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Mar 4, 2024
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.