Enables GQA support in the prefix prefill kernels #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighingnow
force-pushed
the
ht/prefix-gqa
branch
from
c99806b to
1f91dfb
Compare
|
The failure in CI's "Model Test" shouldn't be caused by this pull request, and I have noticed the same failure in other PR as well as main. |
WoosukKwon
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
@sighingnow Awesome! Thanks for submitting the PR! Left a minor comment on a variable name.
Signed-off-by: Tao He <[email protected]>
sighingnow
force-pushed
the
ht/prefix-gqa
branch
from
1f91dfb to
877deb8
Compare
|
@sighingnow Thanks for the fix! I will merge the PR once it passes the CI tests. |
Thank you! |
Hi @WoosukKwon, CI turns green now. (Just a polite reminding). |
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Mar 4, 2024
Signed-off-by: Tao He <[email protected]>
UranusSeven
reviewed
Mar 7, 2024
| @@ -17,12 +18,14 @@ | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("num_heads", NUM_HEADS) | |||
| @pytest.mark.parametrize("num_queries_per_kv", NUM_HEADS) | |||
There was a problem hiding this comment.
Should this parameter be NUM_QUERIES_PER_KV?
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Tao He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.