Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Fix type annotation in fused moe #3045

Merged
merged 2 commits into from
Feb 27, 2024
Merged

[Minor] Fix type annotation in fused moe #3045

merged 2 commits into from
Feb 27, 2024

Conversation

WoosukKwon
Copy link
Collaborator

No description provided.

@WoosukKwon WoosukKwon marked this pull request as ready for review February 27, 2024 02:44
pcmoritz
pcmoritz approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small correction as per comment above, otherwise it looks great, thanks for fixing this :)

@WoosukKwon WoosukKwon merged commit 4bd18ec into main Feb 27, 2024
18 of 22 checks passed
@WoosukKwon WoosukKwon deleted the minor-typefix branch February 27, 2024 03:44
xjpang pushed a commit to xjpang/vllm that referenced this pull request Mar 4, 2024
@WoosukKwon
[Minor] Fix type annotation in fused moe (vllm-project#3045)
4889c20
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
@WoosukKwon
[Minor] Fix type annotation in fused moe (vllm-project#3045)
f7382f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WoosukKwon @pcmoritz