Skip to content

2019 01 21 Open NEST Developer Video Conference

terhorstd edited this page Jan 21, 2019 · 4 revisions

previous | list | next

Agenda

  1. Welcome

  2. Info/Discussion on git commit messages (speaker @clinssen)

    • some commit messages only make sense in the context of current development in the specific branch, but is mostly useless after merge

    • blame based on commits

    • distinguish between what changed (diff) and why it changed (← commit messages!!)

    • has to be part of code review

    • do not bundle many different changes in the same commit

    • 6 1/2 rules for messages

      1. correct name and mail address
      2. atomic commits: separate commits for logically separate changes
      3. "if applied, this commit will…" {commit message}
      4. be descriptive: why (explain), how (justify), what (effects)
      5. be concise (single line <50 <70 chars (git limit))
      6. cross-reference where possible
      7. have consistent style, capital letter?, full stop?, …
  3. Review of NEST User Mailing List

    • little activity
  4. Review of open Github Pull Request

  5. Review of open Github Issues

Clone this wiki locally