-
Notifications
You must be signed in to change notification settings - Fork 473
Move all download state to browser store #7050
Comments
This is a bigger refactoring and may need to be broken down more once work starts. |
First part here is done in: #7103 |
7136: Closes #7103 #5217: DownloadService: Read initial download state from store r=Amejia481 a=csadilek This moves the queued download state from the manager to the store, which cleans things up and also fixes #5217. Keeping the changeset as small as possible so we can continue in #7050 and move the remaining state as well. Tested various cases will do more now and also open PRs for R-B and Fenix. Co-authored-by: Christian Sadilek <[email protected]>
Changes made for this have affected the fix for mozilla-mobile/fenix#9044 . I'll take a look on the Fenix side and see how I can resolve those conflicts. Edit: Or should I wait for this to be finished? |
I think you could continue on Fenix, Is there something in particular that it's blocking you? |
@Amejia481 Yeah, you're right, if the |
I want to add a Download Manager Center Activity in my browser powered by android-components. |
We are going to work on a similar feature on Fenix mozilla-mobile/fenix#349 cc @kglazko |
I filed #7673 for it |
@marcinwiacek now #7698 landed this should include the values that you need. We are going to work on #7761 next as we want downloads to be on memory in the store even if they are completed, after that we want to work on #7762 for this data to be persisted on disk. |
We have downloads in the browser store now, so I'm going to close this. 🙂 |
We currently keep additional application state for downloads in the
DownloadService
(seedownloadJobs
) andDownloadManager
(seequeuedDownloads
).Having all this state in the store will make it easier to implement additional download UI in the future. It also solves the problem described in #5217 where we have to pass the download object (and the full URL) to the download intent which may be too large in case of data URIs. If the service has access to the store it can simply read the state from there.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: