Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add downloads management support to DownloadManager #7227

Closed
keianhzo opened this issue Jun 3, 2020 · 1 comment
Closed

Add downloads management support to DownloadManager #7227

keianhzo opened this issue Jun 3, 2020 · 1 comment
Labels
<download> Component: feature-download 🌟 feature New functionality and improvements

Comments

@keianhzo
Copy link
Contributor

keianhzo commented Jun 3, 2020

In FxR we are currently using a custom DownloadManager based implementation for Downloads. We would like to migrate to FetchDownloadManager to unify the Http stack using a GeckoWebExecutor.

One of the issues we have found is that FetchDownloadManager doesn't support Downloads querying/removing and we need that to update the UI: get downloads status, remove a download/s, etc

It would help if FetchDownloadManager provided a querying mechanism similar to the DownloadManager query and remove methods so we can get the current downloads status or cancel/stop/remove downloads.

As an alternative the completed downloads could be fed to the DownloadManager so we could always get the finished downloads and get the ongoing through onDownloadStopped but we would still be missing some downloads management methods like cancel/stop/remove.

┆Issue is synchronized with this Jira Task

@pocmo pocmo added <download> Component: feature-download 🌟 feature New functionality and improvements labels Jun 3, 2020
@pocmo
Copy link
Contributor

pocmo commented Jun 3, 2020

For the in-memory state (e.g. showing status) #7050 will be helpful since that will move all the internal state from the service to our browser store where components the app (and UI) can use it. (which may be another reason to use the FxR <-> AC bridge). With that I think we may also be able to provide "use cases" that allow to cancel, stop etc. currently active downloads. Adding a persistent storage to that is something we eventually want to do too, but that is a bigger project.

@pocmo pocmo added this to the Triage Archive milestone Jul 27, 2020
@data-sync-user data-sync-user changed the title Add downloads management support to DownloadManager FNX3-22747 ⁃ Add downloads management support to DownloadManager Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX3-22747 ⁃ Add downloads management support to DownloadManager FNX2-18257 ⁃ Add downloads management support to DownloadManager Aug 5, 2020
@st3fan st3fan changed the title FNX2-18257 ⁃ Add downloads management support to DownloadManager Add downloads management support to DownloadManager Aug 5, 2020
@pocmo pocmo removed this from the Triage Archive milestone Oct 8, 2020
@pocmo pocmo closed this as completed Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<download> Component: feature-download 🌟 feature New functionality and improvements
Projects
None yet
Development

No branches or pull requests

2 participants