This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 473
Crash when downloading a large data URI #5217
Labels
Milestone
Comments
MarcLeclair
changed the title
Webpage gets redirected when given an image Data URI and crashes if the URI is too big..
Webpage gets redirected when given an image Data URI and crashes if the URI is too big.
Dec 2, 2019
jonalmeida
added
<app-links>
Component: feature-app-links
🐞 bug
Something isn't working
labels
Dec 3, 2019
cc: @rocketsroger for reference. |
csadilek
changed the title
Webpage gets redirected when given an image Data URI and crashes if the URI is too big.
Crash when downloading a large data URI
May 19, 2020
csadilek
added
<download>
Component: feature-download
and removed
<app-links>
Component: feature-app-links
labels
May 19, 2020
Removing the app-link label. This is no longer redirecting, but crashing because we're storing the data URI in the download object which passed as intent extras:
|
csadilek
added a commit
to csadilek/android-components
that referenced
this issue
May 19, 2020
csadilek
added a commit
to csadilek/android-components
that referenced
this issue
May 19, 2020
bors bot
pushed a commit
that referenced
this issue
May 19, 2020
7028: Issue #5217: Skip check to open about/data/js URLs in external apps r=rocketsroger a=csadilek This prevents looking up external apps for `data:`, `javascript:` and `about:` URLs. We don't need to look for external apps in these cases and the former actually causes crashes when the URL is too large `TransactionTooLargeException` as the intent contains the entire URL. Co-authored-by: Christian Sadilek <[email protected]>
This was referenced May 20, 2020
csadilek
added a commit
to csadilek/android-components
that referenced
this issue
May 26, 2020
… initial download state from store
csadilek
added a commit
to csadilek/android-components
that referenced
this issue
May 27, 2020
… initial download state from store
csadilek
added a commit
to csadilek/android-components
that referenced
this issue
May 27, 2020
… initial download state from store
csadilek
added a commit
to csadilek/android-components
that referenced
this issue
May 27, 2020
… initial download state from store
csadilek
added a commit
to csadilek/android-components
that referenced
this issue
May 27, 2020
… initial download state from store
csadilek
added a commit
to csadilek/android-components
that referenced
this issue
May 28, 2020
… initial download state from store
csadilek
added a commit
to csadilek/android-components
that referenced
this issue
May 28, 2020
… initial download state from store
csadilek
added a commit
to csadilek/android-components
that referenced
this issue
May 28, 2020
…state to browser store
Vishwa-Mozilla
pushed a commit
to Vishwa-Mozilla/android-components
that referenced
this issue
Jun 5, 2020
…state to browser store
Vishwa-Mozilla
pushed a commit
to Vishwa-Mozilla/android-components
that referenced
this issue
Jun 12, 2020
Vishwa-Mozilla
pushed a commit
to Vishwa-Mozilla/android-components
that referenced
this issue
Jun 12, 2020
…state to browser store
Vishwa-Mozilla
pushed a commit
to Vishwa-Mozilla/android-components
that referenced
this issue
Jun 12, 2020
…state to browser store
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps to reproduce
Expected behavior
If the Data URI is an image, a dialogue should pop up to ask the user if they want to download the image.
Actual behavior
Application crashes with a TransactionTooLargeException
Device information
Notes
The application redirects because ( from what I can gather), we check for the "new" url hostname versus our session, which in this case will be different. From there, we redirect with an intent. In the example above, the picture on the NASA website is ~1.2MB which will lead to the application trying to send an intent that's too big (data parcel size 3473380 bytes in my case).
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: