[Bug]Download Dialog inoperational

[codrut-topliceanu]

DynamicDownloadDialog which appears onDownloadStopped no longer displays size of downloaded file, "open" button no longer works, and its instance is no longer tied to the tab that spawned it.

Steps to reproduce

1. Go to www.wikipedia.org
2. Long press on wikipedia logo
3. Choose "Save image"
4. Wait for the Download Dialog to appear

Expected behavior

• "Download completed" should be followed by the size of the file downloaded e.g.: (0.5 MB)
• Pressing "Open" should open the downloaded file
• changing tabs should hide the dialog until returning to its parent tab

Actual behavior

• "Download completed" is followed by "(null)"
• "Open" button no longer works properly
• Download Dialog instance is no longer tied to the tab that spawned it

Device information

• Android device: Pixel 3XL & Pixel 4 (Android 10)
• Fenix version: latest nightly

Note: Waiting for mozilla-mobile/android-components#7050 to close

┆Issue is synchronized with this Jira Task

[Amejia481]

""Download completed" is followed by "(null)" The null issue will covered by mozilla-mobile/android-components#7308

[liuche]

Maybe this is also related to/causing #11107, where the download size is not showing up, so the download progress is also wrong?

[codrut-topliceanu]

I worked on the latest master yesterday and #11107 didn't come up. But I haven't tried google drive download.

[codrut-topliceanu]

Needs mozilla-mobile/android-components#7365 to be merged before PR for this issue will be testable.

[AndiAJ]

Hi, verified as fixed on the latest Nightly Build #200619 from 6/19 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video